Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jdk23 functional tests don't compile on Windows, related to OpenJCEPlus #20004

Closed
pshipton opened this issue Aug 15, 2024 · 6 comments · Fixed by adoptium/aqa-tests#5512
Closed

jdk23 functional tests don't compile on Windows, related to OpenJCEPlus #20004

pshipton opened this issue Aug 15, 2024 · 6 comments · Fixed by adoptium/aqa-tests#5512
Assignees
@llxia
Labels
comp:test jdk23
Milestone
Java 23 (0.47)

Comments

@pshipton
Copy link
Member

Example link, none of sanity,extended,special functional testing compiles.
https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdk23_j9_special.functional_x86-64_windows_testList_0/2

09:51:40      [javac] C:\Users\jenkins\workspace\Test_openjdk23_j9_special.functional_x86-64_windows_testList_0\aqa-tests\functional\OpenJcePlusTests\OpenJCEPlus\src\test\java\ibm\jceplus\junit\base\BaseTestRSAPSSSignature.java:202: error: cannot find symbol
09:51:40      [javac]         X509v1CertificateBuilder builder = new X509v1CertificateBuilder(issuer, BigInteger.ONE, validityBeginDate, validityEndDate,
09:51:40      [javac]         ^
09:51:40      [javac]   symbol:   class X509v1CertificateBuilder
09:51:40      [javac]   location: class BaseTestRSAPSSSignature
09:51:40      [javac] C:\Users\jenkins\workspace\Test_openjdk23_j9_special.functional_x86-64_windows_testList_0\aqa-tests\functional\OpenJcePlusTests\OpenJCEPlus\src\test\java\ibm\jceplus\junit\base\BaseTestRSAPSSSignature.java:202: error: cannot find symbol
09:51:40      [javac]         X509v1CertificateBuilder builder = new X509v1CertificateBuilder(issuer, BigInteger.ONE, validityBeginDate, validityEndDate,
09:51:40      [javac]                                                ^
09:51:40      [javac]   symbol:   class X509v1CertificateBuilder
09:51:40      [javac]   location: class BaseTestRSAPSSSignature
09:51:40      [javac] C:\Users\jenkins\workspace\Test_openjdk23_j9_special.functional_x86-64_windows_testList_0\aqa-tests\functional\OpenJcePlusTests\OpenJCEPlus\src\test\java\ibm\jceplus\junit\base\BaseTestRSAPSSSignature.java:205: error: cannot find symbol
09:51:40      [javac]         ContentSigner signer = new JcaContentSignerBuilder(null).setProvider(new BouncyCastleProvider())
09:51:40      [javac]         ^
09:51:40      [javac]   symbol:   class ContentSigner
09:51:40      [javac]   location: class BaseTestRSAPSSSignature
09:51:40      [javac] C:\Users\jenkins\workspace\Test_openjdk23_j9_special.functional_x86-64_windows_testList_0\aqa-tests\functional\OpenJcePlusTests\OpenJCEPlus\src\test\java\ibm\jceplus\junit\base\BaseTestRSAPSSSignature.java:205: error: cannot find symbol
09:51:40      [javac]         ContentSigner signer = new JcaContentSignerBuilder(null).setProvider(new BouncyCastleProvider())
09:51:40      [javac]                                    ^
09:51:40      [javac]   symbol:   class JcaContentSignerBuilder
09:51:40      [javac]   location: class BaseTestRSAPSSSignature
09:51:40      [javac] C:\Users\jenkins\workspace\Test_openjdk23_j9_special.functional_x86-64_windows_testList_0\aqa-tests\functional\OpenJcePlusTests\OpenJCEPlus\src\test\java\ibm\jceplus\junit\base\BaseTestRSAPSSSignature.java:207: error: cannot find symbol
09:51:40      [javac]         X509CertificateHolder holder = builder.build(signer);
09:51:40      [javac]         ^
09:51:40      [javac]   symbol:   class X509CertificateHolder
09:51:40      [javac]   location: class BaseTestRSAPSSSignature
09:51:40      [javac] C:\Users\jenkins\workspace\Test_openjdk23_j9_special.functional_x86-64_windows_testList_0\aqa-tests\functional\OpenJcePlusTests\OpenJCEPlus\src\test\java\ibm\jceplus\junit\base\BaseTestRSAPSSSignature.java:209: error: cannot find symbol
09:51:40      [javac]         JcaX509CertificateConverter converter = new JcaX509CertificateConverter()
09:51:40      [javac]         ^
09:51:40      [javac]   symbol:   class JcaX509CertificateConverter
09:51:40      [javac]   location: class BaseTestRSAPSSSignature
09:51:40      [javac] C:\Users\jenkins\workspace\Test_openjdk23_j9_special.functional_x86-64_windows_testList_0\aqa-tests\functional\OpenJcePlusTests\OpenJCEPlus\src\test\java\ibm\jceplus\junit\base\BaseTestRSAPSSSignature.java:209: error: cannot find symbol
09:51:40      [javac]         JcaX509CertificateConverter converter = new JcaX509CertificateConverter()
09:51:40      [javac]                                                     ^
09:51:40      [javac]   symbol:   class JcaX509CertificateConverter
09:51:40      [javac]   location: class BaseTestRSAPSSSignature
09:51:42      [javac] 12 errors
@pshipton pshipton added this to the Java 23 (0.47) milestone Aug 15, 2024
@pshipton pshipton added the jdk23 label Aug 15, 2024
@pshipton
Copy link
Member Author

@jasonkatonica @llxia pls take a look

@llxia
Copy link
Contributor

llxia commented Aug 16, 2024

DYNAMIC_COMPILE needs to be set to true for functional tests. In this case, we only compile what is needed.

@pshipton
Copy link
Member Author

pshipton commented Aug 16, 2024 •
edited
Loading

Re-running with DYNAMIC_COMPILE and Lan to fix the pipeline so this is set in the future.

@llxia llxia self-assigned this Aug 16, 2024
@llxia llxia mentioned this issue Aug 20, 2024
Merged
@llxia
Copy link
Contributor

llxia commented Aug 20, 2024

For now, we will regen all functional test builds on wins with DYNAMIC_COMPILE = true.
The issue will be fixed via adoptium/aqa-tests#5512

llxia added a commit to llxia/aqa-tests that referenced this issue Aug 20, 2024
@llxia
Allow user to set DYNAMIC_COMPILE
da4a90b 
related: eclipse-openj9/openj9#20004

Signed-off-by: Lan Xia <[email protected]>
@llxia llxia mentioned this issue Aug 20, 2024
Merged
@llxia
Copy link
Contributor

llxia commented Aug 20, 2024

JDK23 windows functional jobs are auto-generated (link)

llxia added a commit to llxia/aqa-tests that referenced this issue Aug 20, 2024
@llxia
Improve AQA_Test_Pipeline for release testing
5d0f06e 
related: adoptium#5510
fixes: adoptium#5509
fixes: eclipse-openj9/openj9#20004

Signed-off-by: Lan Xia <[email protected]>
@pshipton
Copy link
Member Author

I'll go ahead and close this one then.

pshipton pushed a commit to adoptium/aqa-tests that referenced this issue Aug 20, 2024
@llxia @pshipton
Allow user to set DYNAMIC_COMPILE
8e050c2 
related: eclipse-openj9/openj9#20004

Signed-off-by: Lan Xia <[email protected]>
smlambert pushed a commit to adoptium/aqa-tests that referenced this issue Aug 28, 2024
@llxia
Improve AQA_Test_Pipeline for release testing (#5512)
ac72d07 
related: #5510
fixes: #5509
fixes: eclipse-openj9/openj9#20004

Signed-off-by: Lan Xia <[email protected]>
llxia added a commit to llxia/aqa-tests that referenced this issue Aug 28, 2024
@llxia
Improve AQA_Test_Pipeline for release testing (adoptium#5512)
d70a806 
related: adoptium#5510
fixes: adoptium#5509
fixes: eclipse-openj9/openj9#20004

Signed-off-by: Lan Xia <[email protected]>
pshipton pushed a commit to adoptium/aqa-tests that referenced this issue Aug 29, 2024
@llxia @pshipton
Improve AQA_Test_Pipeline for release testing (#5512)
000eb85 
related: #5510
fixes: #5509
fixes: eclipse-openj9/openj9#20004

Signed-off-by: Lan Xia <[email protected]>
llxia added a commit to llxia/aqa-tests that referenced this issue Aug 29, 2024
@llxia
Improve AQA_Test_Pipeline for release testing (adoptium#5512)
72d81e7 
related: adoptium#5510
fixes: adoptium#5509
fixes: eclipse-openj9/openj9#20004

Signed-off-by: Lan Xia <[email protected]>
LongyuZhang pushed a commit to adoptium/aqa-tests that referenced this issue Aug 29, 2024
@llxia
(v1.0.4-release) backport AQA_Test_Pipeline enhancements (#5533)
6280d2a 
* Improve AQA_Test_Pipeline for release testing (#5512)

related: #5510
fixes: #5509
fixes: eclipse-openj9/openj9#20004

Signed-off-by: Lan Xia <[email protected]>

* Limit FIPS functional testing on OpenJcePlusTests and security

related: backlog/issues/1494

Signed-off-by: Lan Xia <[email protected]>

---------

Signed-off-by: Lan Xia <[email protected]>
llxia added a commit to llxia/aqa-tests that referenced this issue Sep 6, 2024
@llxia
Improve AQA_Test_Pipeline for release testing (adoptium#5512)
85e9e6c 
related: adoptium#5510
fixes: adoptium#5509
fixes: eclipse-openj9/openj9#20004

Signed-off-by: Lan Xia <[email protected]>
pshipton pushed a commit to adoptium/aqa-tests that referenced this issue Sep 6, 2024
@llxia @pshipton
Improve AQA_Test_Pipeline for release testing (#5512)
ffdedf1 
related: #5510
fixes: #5509
fixes: eclipse-openj9/openj9#20004

Signed-off-by: Lan Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llxia llxia

Labels
comp:test jdk23
Projects
None yet
Milestone
Java 23 (0.47)
Development

Successfully merging a pull request may close this issue.

Improve AQA_Test_Pipeline for release testing llxia/aqa-tests
2 participants
@pshipton @llxia