Separate tests that rely on SecurityManager (Java8andUp) #14442

EricYangIBM · 2022-02-04T20:04:51Z

SecurityManager will be removed in a future jdk. Separate tests that
rely on it so that they can be easily disabled in the future.

Issue: #14412
Signed-off-by: Eric Yang [email protected]

test/functional/Java8andUp/testng.xml

EricYangIBM · 2022-02-09T21:06:05Z

Added compilation excludes

pshipton · 2022-02-09T22:14:40Z

We don't want to actually exclude the tests for jdk19+ until it's determined the SecurityManager is removed in jdk19. I was just a guess. We want to be ready to do so quickly, so we aren't blocked from running tests for a month when the change happens.

JasonFengJ9 · 2022-02-10T13:28:17Z

We don't want to actually exclude the tests for jdk19+ until it's determined the SecurityManager is removed in jdk19. I was just a guess. We want to be ready to do so quickly, so we aren't blocked from running tests for a month when the change happens.

I think this PR is preparing us to continue running tests when the SecurityManger related classes are removed in JDK19 or a future release. If it doesn't happen at JDK19, the change required is to just put JDK19 back to the allowed Java levels <matches string="${JDK_VERSION}" pattern="^(8|9|(1[0-8]))$$" /> (one line modification), otherwise this PR will have to be developed in short time period along with quite a few other places.

A list of deprecated APIs for removal:

java.lang.System::{setSecurityManager, getSecurityManager}
java.security.{Policy, PolicySpi, Policy.Parameters}
java.security.{AccessController, AccessControlContext, AccessControlException, DomainCombiner}

java.lang.Thread::checkAccess
java.lang.ThreadGroup::checkAccess
java.util.logging.LogManager::checkAccess
java.util.concurrent.Executors::{privilegedCallable, privilegedCallableUsingCurrentClassLoader, privilegedThreadFactory}
java.rmi.RMISecurityManager
javax.security.auth.SubjectDomainCombiner and javax.security.auth.Subject::{doAsPrivileged, getSubject}

fyi @EricYangIBM

pshipton · 2022-02-10T14:02:48Z

If it doesn't happen at JDK19, the change required is to just put JDK19 back to the allowed Java levels

I can agree with that, as long as we have an issue in the 0.34 milestone plan to ensure we re-enable the tests if necessary. Ideally referring to all the PRs / places to fix. I've created the 0.34 milestone.

EricYangIBM · 2022-02-10T14:38:51Z

test/functional/Java8andUp/playlist.xml

+			<version>15</version>
+			<version>16</version>
+			<version>17</version>
+			<version>18</version>


We will also have to add to versions. (Is there a better way than listing all the versions individually?)

@renfeiw @llxia do we support something like <version>8-18</version>?

Currently we don't, we can have something like this in the future.

Just wondering if this[1] is the playlist version parsing in question?

[1] https://github.com/adoptium/TKG/blob/44a1e0a14c6e33d7c1dc10404ce04ef8af37fd0f/src/org/testKitGen/TestInfoParser.java#L188-L206

Yes, we have a plan to add something like [8,18]. But we also need to support it in the internal perl tkg as well.

JasonFengJ9 · 2022-02-16T18:47:20Z

Are there more changes coming for following tests?

Java8andUp/src/org/openj9/test/annotationPackage/Test_PackageAnnotation.java
Java8andUp/src/org/openj9/test/vmArguments/VmArgumentTests.java
Java8andUp/src_80/org/openj9/test/java/lang/Test_Class.java
Java8andUp/src_90/org/openj9/test/java/lang/Test_Class.java

EricYangIBM · 2022-02-16T18:52:11Z

Java8andUp/src/org/openj9/test/vmArguments/VmArgumentTests.java

Is this related to security manager? -Djava.security.policy=/opt/IBM/WebSphere/AppServer80/profiles/AppSrv01/properties/server.policy

JasonFengJ9 · 2022-02-16T18:55:08Z

Is this related to security manager? -Djava.security.policy=/opt/IBM/WebSphere/AppServer80/profiles/AppSrv01/properties/server.policy

Usually java.security.policy is related to SecurityManager [1].

[1] https://docs.oracle.com/javase/8/docs/technotes/guides/security/PolicyFiles.html

EricYangIBM · 2022-02-16T19:21:15Z

For the two Test_Class.java, since they are src_80 and src_90 won't they not be compiled for jdk19+?
Also for the VmArgumentTests.java I think we can just check the version at runtime and add "-Djava.security.policy=/opt/IBM/WebSphere/AppServer80/profiles/AppSrv01/properties/server.policy" if the version is less than 19

JasonFengJ9 · 2022-02-16T20:19:43Z

For the two Test_Class.java, since they are src_80 and src_90

Scratch these two then, on the other hand, it means src_90 isn't used at all since there is no Java 9 build/test.

Also for the VmArgumentTests.java I think we can just check the version at runtime and add "-Djava.security.policy=/opt/IBM/WebSphere/AppServer80/profiles/AppSrv01/properties/server.policy" if the version is less than 19

Runtime check is fine for this test.

EricYangIBM · 2022-02-16T20:55:10Z

I added the runtime check for VmArgumentTests and removed the AccessController.doPrivileged in Test_PackageAnnotation (SecurityException wasn't thrown, also only used for logging so probably fine)

Note: we will have to change if (VersionCheck.major() < 19) if our assumption about which jdk deprecates SecurityManager is wrong

JasonFengJ9 · 2022-02-17T14:58:17Z

test/functional/Java8andUp/build.xml

+							<exclude name="org/openj9/test/java/lang/invoke/Test_MethodHandleInfo_SM.java" />
+							<exclude name="org/openj9/test/java/lang/Test_ClassLoader_SM.java" />
+							<exclude name="org/openj9/test/java/lang/Test_J9VMInternals.java" />
+							<exclude name="org/openj9/test/java/lang/Test_J9VMInternalsImpl.java" />


Some sub-tests seem applicable to JDK levels w/o SecurityManager related classes such as TestNCDFE.runTest1() within test_checkPackageAccess().

Based on the comment TestNG parses the test file, which interferes with the classloading under test I added the security manager test classes with the same two file pattern now

JasonFengJ9 · 2022-02-17T16:03:16Z

test/functional/Java8andUp/playlist.xml

+			<version>15</version>
+			<version>16</version>
+			<version>17</version>
+			<version>18</version>


Only 11/17/18 are required.

JasonFengJ9 · 2022-02-17T16:04:05Z

test/functional/Java8andUp/playlist.xml

+	-groups $(TEST_GROUP) \
+	-excludegroups $(DEFAULT_EXCLUDE); \
+	$(TEST_STATUS)</command>
+		<platformRequirements>^vm.hrt</platformRequirements>


vm.hrt discontinued long time ago, this platformRequirements is not needed.

JasonFengJ9 · 2022-02-17T16:04:44Z

test/functional/Java8andUp/playlist.xml

+			<version>17</version>
+			<version>18</version>
+		</versions>
+		<aot>nonapplicable</aot>


I think this aot limitation is not needed either.

JasonFengJ9 · 2022-02-17T18:58:00Z

test/functional/Java8andUp/playlist.xml

+	-groups $(TEST_GROUP) \
+	-excludegroups $(DEFAULT_EXCLUDE); \
+	$(TEST_STATUS)</command>
+		<platformRequirements>^vm.hrt</platformRequirements>


Similarly not required.

JasonFengJ9 · 2022-02-17T19:00:36Z

test/functional/Java8andUp/playlist.xml

+			<version>15</version>
+			<version>16</version>
+			<version>17</version>
+			<version>18</version>


Only need 11/17/18, assuming this is a SM version of JCL_Test_none_SCC which is for 11+.

JasonFengJ9 · 2022-02-17T19:04:47Z

test/functional/Java8andUp/playlist.xml

+			<version>15</version>
+			<version>16</version>
+			<version>17</version>
+			<version>18</version>


Only 11/17/18 are needed.

JasonFengJ9 · 2022-02-17T19:05:05Z

test/functional/Java8andUp/playlist.xml

+	-groups $(TEST_GROUP) \
+	-excludegroups $(DEFAULT_EXCLUDE); \
+	$(TEST_STATUS)</command>
+		<platformRequirements>^vm.hrt</platformRequirements>


Not required.

JasonFengJ9 · 2022-02-17T19:06:11Z

test/functional/Java8andUp/playlist.xml

+			<version>15</version>
+			<version>16</version>
+			<version>17</version>
+			<version>18</version>


Only 11/17/18 are required.

JasonFengJ9 · 2022-02-18T15:24:55Z

test/functional/Java8andUp/build.xml

+							<src path="src_110_up" />
+							<src path="${src_version}" />
+							<src path="${src_90_jcl}" />
+							<src path="${src_access}" />


The script reads better w/o large number of duplicated elements. Can you try something like

<path id="src.path"> <pathelement path="${src}/"/> ... <pathelement path="${src_access}"/> ... </path>

The src.path can be shared among targets.

<javac ...> <sourcepath refid="src.path"/> ... </javac>

Managed to remove duplication of src and class path using a property and path filesets

JasonFengJ9 · 2022-02-22T16:08:33Z

test/functional/Java8andUp/build.xml

+							<compilerarg line='${addExports}' />
+							<compilerarg line='${addExports_90_jcl}' />
+							<compilerarg line='${addExports_version}' />
+							<compilerarg line='--add-modules openj9.sharedclasses' />


It would be nice to remove duplicated compilerarg w/ something like

<property name="common-args" value="${addExports} ${addExports_90_jcl} ..." /> <compilerarg line="${common-args}" />

JasonFengJ9 · 2022-02-22T16:38:04Z

test/functional/Java8andUp/src_110_up/org/openj9/test/java/lang/Test_Class_SM.java

+ * SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 OR LicenseRef-GPL-2.0 WITH Assembly-exception
+ *******************************************************************************/
+
+import org.testng.annotations.AfterMethod;


It is not required in this class.

JasonFengJ9 · 2022-02-22T16:38:24Z

test/functional/Java8andUp/src_110_up/org/openj9/test/java/lang/Test_Class_SM.java

+import org.testng.annotations.AfterMethod;
+import org.testng.annotations.Test;
+import org.testng.log4testng.Logger;
+import org.testng.annotations.BeforeMethod;


Not required.

JasonFengJ9 · 2022-02-22T16:45:39Z

test/functional/Java8andUp/src_110_up/org/openj9/test/java/lang/Test_Class_SM.java

+@Test
+public void test_getMethods_subtest2() {
+	java.security.PrivilegedAction action = new java.security.PrivilegedAction() {
+		public Object run() {


Since these existing code are being moved to a new class, please help some cleanup.

Suggested change

public Object run() {

PrivilegedAction<Object> action = new PrivilegedAction<Object>() {

@Override

public Object run() {

JasonFengJ9 · 2022-02-22T16:46:51Z

test/functional/Java8andUp/src_110_up/org/openj9/test/java/lang/Test_Class_SM.java

+				java.net.URL url = new java.net.URL("file:" + file.getPath());
+				ClassLoader loader = new java.net.URLClassLoader(new java.net.URL[]{url}, null);
+
+				Class cls_E = Class.forName("org.openj9.resources.classinheritance.E", false, loader);


Suggested change

Class cls_E = Class.forName("org.openj9.resources.classinheritance.E", false, loader);

Class<?> cls_E = Class.forName("org.openj9.resources.classinheritance.E", false, loader);

JasonFengJ9 · 2022-02-22T16:48:14Z

test/functional/Java8andUp/src_110_up/org/openj9/test/java/lang/Test_Class_SM.java

+				Support_Resources.copyFile(resources, null, "openj9tr_general.jar");
+				File file = new File(resources.toString() + "/openj9tr_general.jar");
+				java.net.URL url = new java.net.URL("file:" + file.getPath());
+				ClassLoader loader = new java.net.URLClassLoader(new java.net.URL[]{url}, null);


Suggested change

ClassLoader loader = new java.net.URLClassLoader(new java.net.URL[]{url}, null);

ClassLoader loader = new URLClassLoader(new java.net.URL[]{url}, null);

JasonFengJ9 · 2022-02-22T16:49:07Z

test/functional/Java8andUp/src_110_up/org/openj9/test/java/lang/Test_Class_SM.java

+			return null;
+		}
+	};
+	java.security.AccessController.doPrivileged(action);


Suggested change

java.security.AccessController.doPrivileged(action);

AccessController.doPrivileged(action);

JasonFengJ9 · 2022-02-22T16:50:51Z

test/functional/Java8andUp/src_110_up/org/openj9/test/java/lang/Test_Class_SM.java

+	};
+	class MyCombiner implements java.security.DomainCombiner {
+		boolean combine;
+		public java.security.ProtectionDomain[] combine(java.security.ProtectionDomain[] executionDomains, java.security.ProtectionDomain[] parentDomains) {


Suggested change

public java.security.ProtectionDomain[] combine(java.security.ProtectionDomain[] executionDomains, java.security.ProtectionDomain[] parentDomains) {

public ProtectionDomain[] combine(ProtectionDomain[] executionDomains, ProtectionDomain[] parentDomains) {

JasonFengJ9 · 2022-02-22T16:51:09Z

test/functional/Java8andUp/src_110_up/org/openj9/test/java/lang/Test_Class_SM.java

+ */
+@Test
+public void test_getClasses2() {
+	final java.security.Permission privCheckPermission = new java.security.BasicPermission("Privilege check") {


Suggested change

final java.security.Permission privCheckPermission = new java.security.BasicPermission("Privilege check") {

final Permission privCheckPermission = new BasicPermission("Privilege check") {

JasonFengJ9 · 2022-02-22T16:51:26Z

test/functional/Java8andUp/src_110_up/org/openj9/test/java/lang/Test_Class_SM.java

+	final MyCombiner combiner = new MyCombiner();
+	class SecurityManagerCheck extends SecurityManager {
+		String reason;
+		Class checkClass;


Suggested change

Class checkClass;

Class<?> checkClass;

JasonFengJ9

More cleanup for new classes please.

JasonFengJ9 · 2022-02-23T13:56:19Z

test/functional/Java8andUp/build.xml

+							<exclude name="**/Cmvc194280.java" />
+							<exclude name="**/resources/**" />
+							<!-- requires special compilation methods -->
+							<exclude name="**/NoSuchMethod/**" />


These duplicated exclude can be shared via something like

<property name="commonExcludes" value="**/Cmvc194280.java,**/resources/**, ... " /> <javac srcdir="${src}" excludes="${commonExcludes}"

JasonFengJ9 · 2022-02-23T14:34:16Z

test/functional/Java8andUp/src_110_up/org/openj9/test/java/lang/Test_Class_SM.java

+
+import org.openj9.test.support.resource.Support_Resources;
+
+


nitpicking : an extra line.

JasonFengJ9 · 2022-02-23T14:37:15Z

test/functional/Java8andUp/src_110_up/org/openj9/test/java/lang/Test_Class_SM.java

+	private static final Logger logger = Logger.getLogger(Test_Class_SM.class);
+
+@Test
+public void test_getMethods_subtest2() {


nitpicking : pls add an indention to align w/ private static final Logger logger.

JasonFengJ9 · 2022-02-23T14:38:18Z

test/functional/Java8andUp/src_110_up/org/openj9/test/java/lang/Test_Class_SM.java

+		public Object run() {
+			try {
+				File resources = Support_Resources.createTempFolder();
+				String[]	expected_E = new String[] {


nitpicking: use a apace instead of the tab between String[] and expected_E.

JasonFengJ9 · 2022-02-23T14:39:56Z

test/functional/Java8andUp/src_110_up/org/openj9/test/java/lang/Test_Class_SM.java

+				Support_Resources.copyFile(resources, null, "openj9tr_general.jar");
+				File file = new File(resources.toString() + "/openj9tr_general.jar");
+				URL url = new URL("file:" + file.getPath());
+				ClassLoader loader = new URLClassLoader(new URL[]{url}, null);


Suggested change

ClassLoader loader = new URLClassLoader(new URL[]{url}, null);

ClassLoader loader = new URLClassLoader(new URL[] { url }, null);

JasonFengJ9 · 2022-02-23T15:22:40Z

test/functional/Java8andUp/src/org/openj9/test/java/lang/invoke/Test_MethodHandleInfo_SM.java

+			private Class<?> getClass( String className )throws ClassNotFoundException {
+				String classFile = className.replace('.', '/') + ".class";
+				try {
+					InputStream classStream = getClass().getClassLoader().getResourceAsStream( classFile );


nitpicking: additional spaces around classFile

JasonFengJ9 · 2022-02-23T15:23:03Z

test/functional/Java8andUp/src/org/openj9/test/java/lang/invoke/Test_MethodHandleInfo_SM.java

+				String classFile = className.replace('.', '/') + ".class";
+				try {
+					InputStream classStream = getClass().getClassLoader().getResourceAsStream( classFile );
+					if ( classStream == null ) {


nitpicking: additional spaces around classStream == null

JasonFengJ9 · 2022-02-23T15:23:26Z

test/functional/Java8andUp/src/org/openj9/test/java/lang/invoke/Test_MethodHandleInfo_SM.java

+				try {
+					InputStream classStream = getClass().getClassLoader().getResourceAsStream( classFile );
+					if ( classStream == null ) {
+						throw new ClassNotFoundException( "Error loading class : " + classFile );


nitpicking: additional spaces around "Error loading class : " + classFile

JasonFengJ9 · 2022-02-23T15:24:48Z

test/functional/Java8andUp/src/org/openj9/test/java/lang/invoke/Test_MethodHandleInfo_SM.java

+			        Class<?> clazz = defineClass( className, classRep, 0, classRep.length );
+					return clazz;
+				} catch ( IOException e ) {
+					throw new ClassNotFoundException( e.getMessage() );


Suggested change

throw new ClassNotFoundException( e.getMessage() );

DataInputStream in = new DataInputStream(classStream);

in.readFully(classRep);

in.close();

Class<?> clazz = defineClass(className, classRep, 0, classRep.length);

return clazz;

} catch (IOException e) {

throw new ClassNotFoundException(e.getMessage());

nitpicking: remove additional spaces, also a few other places in this class.

JasonFengJ9 · 2022-02-23T15:33:19Z

test/functional/Java8andUp/src/org/openj9/test/vmArguments/VmArgumentTests.java

+
+					expectedArgs = new String[initialExpectedArgs.length + 1];
+					System.arraycopy(initialExpectedArgs, 0, expectedArgs, 0, initialExpectedArgs.length);
+					expectedArgs[initialExpectedArgs.length] = "-Djava.security.policy=/opt/IBM/WebSphere/AppServer80/profiles/AppSrv01/properties/server.policy";


Pls define a string constant to share -Djava.security.policy=/opt/IBM/WebSphere/AppServer80/profiles/AppSrv01/properties/server.policy, probably -Djava.ext.dirs=/opt/IBM/WebSphere/AppServer80/tivoli/tam:/opt/IBM/WebSphere/AppServer80/java/jre/lib/ext as well.

JasonFengJ9 · 2022-02-24T17:57:32Z

Requesting reviews from @llxia @pshipton before asking for rebase & squash the commits.

llxia · 2022-02-24T18:29:38Z

@renfeiw could you help to review this PR? Thanks

EricYangIBM · 2022-02-24T18:34:40Z

I have two other smaller PRs for JLM_Tests and Jsr292 ready: #14562 #14580
@JasonFengJ9 could you please review these as well?

pshipton · 2022-02-24T19:11:17Z

This isn't working on vmfarm, see /jobs_by_status.php?build_id=23133&status=FAILED

[TestNG] [ERROR] 
Cannot find class in classpath: org.openj9.test.java.lang.Test_Class_SM
Exception in thread "main" java.lang.NullPointerException
	at org.testng.TestNG.getStatus(TestNG.java:211)
	at org.testng.TestNG.main(TestNG.java:1324)

I didn't try jenkins (yet) but I assume it's been tested there.

EricYangIBM · 2022-02-24T20:51:44Z

I think the problem is that it is looking for Test_Class_SM and Test_System_SM, both only in src_110_up right now. I will need to add duplicates or move them to src.
Also I will need to add the new SM tests to SE80 tests

EricYangIBM · 2022-02-25T20:39:19Z

Sanity.functional passes for jdk8 and 11: https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/12062/

JasonFengJ9 · 2022-02-25T22:20:53Z

JavaNext(19) doesn't work.

===============================================
Running test truncatedReturnTest_0 ...
===============================================
truncatedReturnTest_0 Start Time: Fri Feb 25 09:45:22 2022 Epoch Time (ms): 1645811122799
variation: NoOptions
JVM_OPTIONS:  
[TestNG] [ERROR]
Cannot find class in classpath: org.openj9.test.java.lang.Test_ClassLoader_SM
Exception in thread "main" java.lang.NullPointerException: Cannot invoke "org.testng.internal.ExitCodeListener.hasTests()" because "this.exitCodeListener" is null
        at org.testng.TestNG.getStatus(TestNG.java:211)
        at org.testng.TestNG.main(TestNG.java:1324)

truncatedReturnTest_0_FAILED

pshipton · 2022-02-25T22:33:18Z

A vmfarm build didn't work either (/build_info.php?build_id=23259), although the problem doesn't seem obviously related to these changes. I'm not sure yet what else it could be.

JasonFengJ9 · 2022-02-25T22:46:25Z

A vmfarm build didn't work either (/build_info.php?build_id=23259)

    [javac] error: Exception thrown while constructing Processor object: JVMCFRE003 bad major version; class=org/apache/logging/log4j/core/config/plugins/processor/PluginProcessor, offset=6
  [antcall] Exiting /bluebird/builds/bld_23259/testing/com.ibm.j9.jit.fiorano/build.xml.

pshipton · 2022-02-25T22:59:04Z

The vmfarm build problem also occurs without these changes so something else has caused it. I'll try these changes again once the other problem is resolved.

EricYangIBM · 2022-02-28T14:33:29Z

Am I correct that all test classes named in testng.xml require a java class? I noticed that the previously excluded test files either were not in testng.xml or they were commented out. I think I'll have to create a separate testng file for the SecurityManager tests

pshipton · 2022-02-28T21:32:01Z

A new vmfarm build passed.

pshipton · 2022-02-28T21:33:01Z

Although that was before the latest changes. I'll run a new one.

pshipton · 2022-02-28T22:47:49Z

Latest changes also passed on vmfarm.

pshipton · 2022-03-01T15:03:03Z

jenkins test sanity xlinux jdk8,jdk11,jdk17,jdk18,jdknext

pshipton · 2022-03-01T21:21:12Z

lgtm, I can see all the new tests running on 11-18, and not on 19.

JCL_Test_SM
JCL_Test_SM_none_SCC

JCL_TEST_Java-Lang_ClassLoader_SM
JCL_TEST_Java-Lang_SM
JCL_TEST_Java-Lang-Invoke_SM
JCL_TEST_IBM-VM_SM

JCL_TEST_Java-Security_SM

JCL_TEST_Java-Security_SM

J9VMInternals_Test_SM

JCL_TEST_Java-Internals_SM

SecurityManager will be removed in a future jdk. Separate tests that rely on it so that they can be easily disabled in the future. Issue: eclipse-openj9#14412 Signed-off-by: Eric Yang <[email protected]>

JasonFengJ9

LGTM
Thanks @EricYangIBM

pshipton · 2022-03-02T23:52:48Z

@renfeiw @llxia any further comments?

renfeiw

LGTM

llxia

LGTM

EricYangIBM added comp:test jdk-head labels Feb 4, 2022

JasonFengJ9 reviewed Feb 7, 2022

View reviewed changes

test/functional/Java8andUp/testng.xml Outdated Show resolved Hide resolved

EricYangIBM force-pushed the sm_Java8andUp branch from 9604e13 to d3a8032 Compare February 10, 2022 14:33

EricYangIBM commented Feb 10, 2022

View reviewed changes

EricYangIBM force-pushed the sm_Java8andUp branch 2 times, most recently from c9df40e to 9f49220 Compare February 15, 2022 18:13

EricYangIBM marked this pull request as ready for review February 15, 2022 20:52

EricYangIBM force-pushed the sm_Java8andUp branch from a2eb843 to b9c1dd6 Compare February 16, 2022 15:25

EricYangIBM requested a review from JasonFengJ9 February 16, 2022 15:26

EricYangIBM force-pushed the sm_Java8andUp branch from b9c1dd6 to a2eb843 Compare February 16, 2022 15:30

JasonFengJ9 reviewed Feb 17, 2022

View reviewed changes

JasonFengJ9 reviewed Feb 18, 2022

View reviewed changes

EricYangIBM force-pushed the sm_Java8andUp branch from cc33cd6 to b572a35 Compare February 18, 2022 18:51

JasonFengJ9 reviewed Feb 22, 2022

View reviewed changes

JasonFengJ9 reviewed Feb 23, 2022

View reviewed changes

JasonFengJ9 requested review from pshipton and llxia February 24, 2022 17:55

EricYangIBM force-pushed the sm_Java8andUp branch from 28848b9 to 383b38f Compare February 24, 2022 20:17

EricYangIBM force-pushed the sm_Java8andUp branch from 83c54fb to 300454d Compare February 28, 2022 20:03

pshipton approved these changes Mar 1, 2022

View reviewed changes

Separate tests that rely on SecurityManager (Java8andUp)

8097a01

SecurityManager will be removed in a future jdk. Separate tests that rely on it so that they can be easily disabled in the future. Issue: eclipse-openj9#14412 Signed-off-by: Eric Yang <[email protected]>

EricYangIBM force-pushed the sm_Java8andUp branch from 690fd9b to 8097a01 Compare March 1, 2022 21:23

JasonFengJ9 approved these changes Mar 2, 2022

View reviewed changes

renfeiw approved these changes Mar 3, 2022

View reviewed changes

llxia approved these changes Mar 3, 2022

View reviewed changes

pshipton merged commit afec275 into eclipse-openj9:master Mar 3, 2022

EricYangIBM deleted the sm_Java8andUp branch March 3, 2022 20:10

	Class cls_E = Class.forName("org.openj9.resources.classinheritance.E", false, loader);
	Class<?> cls_E = Class.forName("org.openj9.resources.classinheritance.E", false, loader);

	ClassLoader loader = new java.net.URLClassLoader(new java.net.URL[]{url}, null);
	ClassLoader loader = new URLClassLoader(new java.net.URL[]{url}, null);

	java.security.AccessController.doPrivileged(action);
	AccessController.doPrivileged(action);

	public java.security.ProtectionDomain[] combine(java.security.ProtectionDomain[] executionDomains, java.security.ProtectionDomain[] parentDomains) {
	public ProtectionDomain[] combine(ProtectionDomain[] executionDomains, ProtectionDomain[] parentDomains) {

	final java.security.Permission privCheckPermission = new java.security.BasicPermission("Privilege check") {
	final Permission privCheckPermission = new BasicPermission("Privilege check") {

-					throw new ClassNotFoundException( e.getMessage() );
+										DataInputStream in = new DataInputStream(classStream);
+					in.readFully(classRep);
+					in.close();
+					Class<?> clazz = defineClass(className, classRep, 0, classRep.length);
+					return clazz;
+				} catch (IOException e) {
+					throw new ClassNotFoundException(e.getMessage());


		import org.openj9.test.support.resource.Support_Resources;

Separate tests that rely on SecurityManager (Java8andUp) #14442

Separate tests that rely on SecurityManager (Java8andUp) #14442

Conversation

EricYangIBM commented Feb 4, 2022

EricYangIBM commented Feb 9, 2022

pshipton commented Feb 9, 2022 • edited Loading

JasonFengJ9 commented Feb 10, 2022

pshipton commented Feb 10, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JasonFengJ9 commented Feb 16, 2022

EricYangIBM commented Feb 16, 2022

JasonFengJ9 commented Feb 16, 2022

EricYangIBM commented Feb 16, 2022 • edited Loading

JasonFengJ9 commented Feb 16, 2022 • edited Loading

EricYangIBM commented Feb 16, 2022 • edited Loading

Choose a reason for hiding this comment

EricYangIBM Feb 17, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JasonFengJ9 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JasonFengJ9 commented Feb 24, 2022

llxia commented Feb 24, 2022

EricYangIBM commented Feb 24, 2022

pshipton commented Feb 24, 2022

EricYangIBM commented Feb 24, 2022

EricYangIBM commented Feb 25, 2022

JasonFengJ9 commented Feb 25, 2022

pshipton commented Feb 25, 2022

JasonFengJ9 commented Feb 25, 2022 • edited Loading

pshipton commented Feb 25, 2022

EricYangIBM commented Feb 28, 2022

pshipton commented Feb 28, 2022

pshipton commented Feb 28, 2022

pshipton commented Feb 28, 2022

pshipton commented Mar 1, 2022

pshipton commented Mar 1, 2022 • edited Loading

JasonFengJ9 left a comment

Choose a reason for hiding this comment

pshipton commented Mar 2, 2022

renfeiw left a comment

Choose a reason for hiding this comment

llxia left a comment

Choose a reason for hiding this comment

pshipton commented Feb 9, 2022 •

edited

Loading

EricYangIBM commented Feb 16, 2022 •

edited

Loading

JasonFengJ9 commented Feb 16, 2022 •

edited

Loading

EricYangIBM commented Feb 16, 2022 •

edited

Loading

EricYangIBM Feb 17, 2022 •

edited

Loading

JasonFengJ9 commented Feb 25, 2022 •

edited

Loading

pshipton commented Mar 1, 2022 •

edited

Loading