From c08a3056dbb12f8b2d8798a829dc3f33ad8213ec Mon Sep 17 00:00:00 2001
From: EverettHanke <forgetekbusiness@gmail.com>
Date: Fri, 8 Nov 2024 00:04:00 -0800
Subject: [PATCH] Annotating when having Injectable Constructor

---
 .../pde/ds/internal/annotations/AnnotationVisitor.java       | 5 +++++
 .../org/eclipse/pde/ds/internal/annotations/Messages.java    | 2 ++
 .../eclipse/pde/ds/internal/annotations/messages.properties  | 1 +
 3 files changed, 8 insertions(+)

diff --git a/ds/org.eclipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/AnnotationVisitor.java b/ds/org.eclipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/AnnotationVisitor.java
index 68e6fedc11..b5bfe5df0a 100644
--- a/ds/org.eclipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/AnnotationVisitor.java
+++ b/ds/org.eclipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/AnnotationVisitor.java
@@ -258,6 +258,11 @@ public boolean visit(TypeDeclaration type) {
 							if (hasInjectableConstructor) {
 								// TODO we should add an error marker that offers a quickfix to upgrade the spec
 								// version to 1.4
+								problemReporter.reportProblem(annotation, null,
+										NLS.bind(
+												Messages.AnnotationProcessor_invalidCompImplClass_injectableConstructor,
+												type.getName().getIdentifier()),
+										type.getName().getIdentifier());
 							}
 							problemReporter.reportProblem(annotation, null,
 									NLS.bind(Messages.AnnotationProcessor_invalidCompImplClass_noDefaultConstructor,
diff --git a/ds/org.eclipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/Messages.java b/ds/org.eclipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/Messages.java
index 306a5ce9ce..c38887e4a8 100644
--- a/ds/org.eclipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/Messages.java
+++ b/ds/org.eclipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/Messages.java
@@ -47,6 +47,8 @@ public class Messages extends NLS {
 
 	public static String AnnotationProcessor_invalidCompImplClass_noDefaultConstructor;
 
+	public static String AnnotationProcessor_invalidCompImplClass_injectableConstructor;
+
 	public static String AnnotationProcessor_invalidCompImplClass_notPublic;
 
 	public static String AnnotationProcessor_invalidCompImplClass_notTopLevel;
diff --git a/ds/org.eclipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/messages.properties b/ds/org.eclipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/messages.properties
index 131243e569..c731eb2f5f 100644
--- a/ds/org.eclipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/messages.properties
+++ b/ds/org.eclipse.pde.ds.annotations/src/org/eclipse/pde/ds/internal/annotations/messages.properties
@@ -25,6 +25,7 @@ AnnotationProcessor_invalidCompImplClass_annotation=Invalid component implementa
 AnnotationProcessor_invalidCompImplClass_enumeration=Invalid component implementation class ''{0}'': enumeration type.
 AnnotationProcessor_invalidCompImplClass_interface=Invalid component implementation class ''{0}'': interface type.
 AnnotationProcessor_invalidCompImplClass_noDefaultConstructor=Invalid component implementation class ''{0}'': no default constructor.
+AnnotationProcessor_invalidCompImplClass_injectableConstructor=Invalid component implementation class ''{0}'': injectable constructor.
 AnnotationProcessor_invalidCompImplClass_compatibleConstructor=Invalid component implementation class ''{0}'': no default or @Activate annotated constructor.
 AnnotationProcessor_invalidCompImplClass_notPublic=Invalid component implementation class ''{0}'': not a public class.
 AnnotationProcessor_invalidCompImplClass_notTopLevel=Invalid component implementation class ''{0}'': not a primary class or static class nested in primary type.