-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1417] Plug-in editor: Runtime tab should show selected package #1418
base: master
Are you sure you want to change the base?
Conversation
@ruspl-afed for the build-failure see #1419. |
Thanks @HannesWell ! After rebasing, everything turns green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HannesWell ! After rebasing, everything turns green.
Better thank @akurtakov for his work on resolving this. :)
About this change: Can't one see the packages from the selection in the list?
On the other hand one can start scrolling and lose it, so it can be helpful to name the selected package(s) explicitly.
But I think we should keep (and fix) the introducing sentence and just append the actually selected packages. But when we are on this it should be adjusted depending on if one or multiple packages are selected:
Either The selected package is <selected-package>
or The selected packages are: <selected-package-list>
.
Or to read it more like a sentence with the following radio choice:
The package <selected-package> is:
or The packages <selected-package-list> are:
...pse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExportPackageVisibilitySection.java
Outdated
Show resolved
Hide resolved
Yes, this is exactly the case, see #1417
I tried this approach in the very beginning and found that we have very limited horizontal space and it is better to avoid all the words except package name itself. And also, section doesn't support Please advice how to proceed better. |
It took me some time to figure whats changed, as I would have expected the information of selected packages (if we want to duplicate that information) would be shown somewhere at the section list on the left. Beside that I'm not sure if it is a good think, just in your example select all packages and it will become very crowded... I also wonder what is the underlying use case to select some packages and then scroll them out of view to afterwards show them on a different place. In any case I would probably for artificially use-case more go like this:
|
Thank you for your comment @laeubi , it turns me back to the question how I came to this artificial use case.
|
Thanks Christoph for your suggestion. I wanted to suggest basically the same but got distracted and forgot to answer. Sorry for that.
I fully support suggestion 1, but in suggestion two, opening a dialog that changes the selection is too much. I would simply stick with an (enhanced) simple label in case multiple packages are selected: |
…ackage The simplest solution would be to use the section description
Is that what you meant? @HannesWell @laeubi |
@ruspl-afed single selection looks fine for me, multi selection should be something like "the selected packages are" where you probabbly set a tooltip text to show the actual list because otherwise if you select say 10 or more package I fear it would somehow explode the available space. |
The simplest solution would be to use the section description
Fixes #1417