Improve collapse all icon

[vogella]

The most "disruptive" icon in the toolbar (in the dark theme) is currently the collapse all icon. Compare is with the min-max icons which look IMHO really good in the screenshot.

@Michael5601 @BeckerWdf if you agree, could you improve this icon? This would be a very fast quick win,

[vogella]

#108

[BeckerWdf]

So what you say is that it's to bright?
So then also the filter icon is quite bright.

[Michael5601]

So what you say is that it's to bright? So then also the filter icon is quite bright.

I also can't see what you mean with disruptive. Can you elaborate?

It is also hard to compare the collapse icon with the right icons as they look like they are from a different "theme". I know they are not but they look better to you in dark mode as they are designed like modern icons. In a modern icon pack every icon would be tested to function in a dark theme.

[HeikoKlare]

Note that the min/max icons are no classic icons at all. These icons are programatically rendered via an ImageDataProvider.

[vogella]

It is too bright and has a blue gradient. I think removing the gradient and making its background a bit transparent would hugely improve the icon.

[vogella]

Current icons:

[vogella]

Suggested new:

[vogella]

Or

or

[BeckerWdf]

I will try to improve the icon.

[BeckerWdf]

"Package Explorer" has the current Icon "Project Explorer" has my changed icon:

I have the impression the stroke color is to pale. The hard thing here is that this should look good on light and dark theme.
If I make the stroke color darker then the contrast ist good on the light background but worse on dark background.

[vogella]

New icon looks already way better than the old one.

[BeckerWdf]

New icon looks already way better than the old one.

I don't agree. The missing color makes it look like it's disabled - especially in the dark theme.

[BeckerWdf]

Suggested new:

It's not possible to judge in Inkscape if this looks good or not. One has to see it on the correct background and inside the workbench to see how it really looks like.

[BeckerWdf]

Or

or

Some as above:
It's not possible to judge in Inkscape if this looks good or not. One has to see it on the correct background and inside the workbench to see how it really looks like.

[merks]

FYI, for some reason your images don't show up:

[BeckerWdf]

FYI, for some reason your images don't show up:

This is a quote from Lars' images. Do they show up?

[merks]

I see it's an issue with quoted images!

My image shows up in Firefox but not in a browser where I've not logged in to GitHub...

[BeckerWdf]

Yet another idea. Now with some blue color (no gradient) so that it does not look disabled in the dark theme:

[vogella]

I dislike the stronger usage of blue in the new proposal make the icon look wither more like it's for Windows95

[merks]

This is just an observation. I'll bet a lot of downstream projects have copies of the expand-all / collapse-all icons so we're bound do have variations of these in the future within the same IDE, e.g.,

• https://github.com/eclipse-emf/org.eclipse.emf/blob/master/plugins/org.eclipse.emf.codegen.ui/icons/full/ctool16/ExpandAll.png
• https://github.com/eclipse-xtext/xtext/blob/main/org.eclipse.xtext.ui/icons/elcl16/expandall.gif

This is not an argument against change, just an observation (that this is what happens when icons are not API and cannot be reused).

[BeckerWdf]

I don't find a solution that is betten compared to what we have today.