Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare 4.28 RC1 #1086

Closed
11 of 13 tasks
MohananRahul opened this issue May 25, 2023 · 22 comments
Closed
11 of 13 tasks

Declare 4.28 RC1 #1086

MohananRahul opened this issue May 25, 2023 · 22 comments

Comments

@MohananRahul
Copy link
Contributor

MohananRahul commented May 25, 2023 •
edited
Loading

Declare 4.28 RC1
A "go" is needed from all the components below to declare this milestone.

Current Candidate

New release Candidate :

Eclipse downloads:
https://download.eclipse.org/eclipse/downloads/drops4/I20230525-0350

Build logs and/or test results (eventually):
https://download.eclipse.org/eclipse/downloads/drops4/I20230525-0350/testResults.php

Software site repository:
https://download.eclipse.org/eclipse/updates/4.28-I-builds

Specific (simple) site repository:
https://download.eclipse.org/eclipse/updates/4.28-I-builds/I20230525-0350

Equinox downloads:
https://download.eclipse.org/equinox/drops/I20230525-0350

Deadlines:

Friday, 2023-May-26, around 1 AM (Eastern): deadline for sign-off (or, by then, comment in this issue when you expect to sign-off).
Friday, 2023-May-26, around 3 AM (Eastern): promote approved build to S-4.28RC1-*, contribute to simultaneous release repo, and announce to mailing lists.
Remember to investigate and document here any failing JUnit tests.

  • Platform:

    • Resources
    • UI
    • Debug
    • Ant
    • SWT
    • Releng

  • JDT:

    • Core
    • Debug
    • UI

  • PDE

  • Equinox
@iloveeclipse
Copy link
Member

There were two merges after I20230524-1800 that probably should go into RC1:

  1. Reverts #183, as it causes the PopupVisibleTimer to be kept running when eclipse.platform.text#208
  2. Fix regression in RenameLinkedMode eclipse-jdt/eclipse.jdt.ui#593

@akurtakov
Copy link
Member

In this case a respin should be started ASAP.

@iloveeclipse
Copy link
Member

  1. @MohananRahul : looks like calendar thinks it is OK to merge now, as it shows green state for Check Code Freeze Period / check-freeze-period / verify-freeze-period (pull_request), see for example Improve JDT onboarding icon for the black theme eclipse-jdt/eclipse.jdt.ui#594
  2. @akurtakov : I will trigger I build now - do you agree?

@akurtakov
Copy link
Member

Please trigger it.

@iloveeclipse
Copy link
Member

https://ci.eclipse.org/releng/job/Builds/job/I-build-4.28/122/

@iloveeclipse
Copy link
Member

New RC1 candidate: https://download.eclipse.org/eclipse/downloads/drops4/I20230525-0350

@vogella
Copy link
Contributor

vogella commented May 25, 2023

I see weird classpath issues with Build id: I20230522-1800 see eclipse-pde/eclipse.pde#602

Will update to https://download.eclipse.org/eclipse/downloads/drops4/I20230525-0350 and see if this goes away.

@vogella
Copy link
Contributor

vogella commented May 25, 2023 •
edited
Loading

I see weird classpath issues with Build id: I20230522-1800 see eclipse-pde/eclipse.pde#602

Will update to https://download.eclipse.org/eclipse/downloads/drops4/I20230525-0350 and see if this goes away.

Nope, still there with Build id: I20230525-0350. Not sure what causes this in this example but a clean all projects fixes it until the next code edit, which indicates that this is an error.

@mpalat
Copy link
Contributor

mpalat commented May 26, 2023

Go for JDT.Core
The intermittent failure is tracked via eclipse-jdt/eclipse.jdt.core#1094

@noopur2507
Copy link
Member

Go from JDT UI.

org.eclipse.jdt.ui.tests.quickfix.SaveParticipantTest is a known intermittent test failure.

@subyssurendran666
Copy link
Contributor

subyssurendran666 commented May 26, 2023 •
edited
Loading

Go from JT.Debug
The intermittent failure is tracked via - eclipse-jdt/eclipse.jdt.debug#28

@elsazac
Copy link
Member

elsazac commented May 26, 2023

Go from SWT.

1 intermittent junit test failure on macOS x86_64 is tracked by eclipse-platform/eclipse.platform.swt#567

@MohananRahul
Copy link
Contributor Author

Go from platform releng

@MohananRahul
Copy link
Contributor Author

MohananRahul commented May 26, 2023 •
edited
Loading

Notification : @tjwatson @HannesWell

@HannesWell
Copy link
Member

Go from PDE.

@Shee43
Copy link
Contributor

Shee43 commented May 26, 2023

Go from Platform.Debug

@iloveeclipse
Copy link
Member

iloveeclipse commented May 26, 2023 •
edited
Loading

@MohananRahul : could you please fix the calendar that allows merging now?
See green Check Code Freeze Period / check-freeze-period / verify-freeze-period (pull_request), for example eclipse-jdt/eclipse.jdt.ui#594

@MohananRahul
Copy link
Contributor Author

@MohananRahul : could you please fix the calendar that allows merging now?
See green Check Code Freeze Period / check-freeze-period / verify-freeze-period (pull_request), for example eclipse-jdt/eclipse.jdt.ui#594

@iloveeclipse Could you please check now.

@vogella
Copy link
Contributor

vogella commented May 26, 2023

@MohananRahul : could you please fix the calendar that allows merging now?

Can someone give @iloveeclipse permission to change this calender directly? I have seen multiple request from Andrey to adjust the calender during the last weeks and it would be much more efficient and less annoying email updates if Andrey could change the calander directly.

@iloveeclipse
Copy link
Member

Could you please check now.

Works after manual re-triggering, see updated state at eclipse-jdt/eclipse.jdt.ui#594
Thanks.

@tjwatson
Copy link
Contributor

Go for Equinox

@Shee43
Copy link
Contributor

Shee43 commented May 26, 2023

Go from Platform UI

The test failures are captured by

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests