From 63239e58db34270f9c6b1bf3585b6f0a781e5000 Mon Sep 17 00:00:00 2001 From: "Kellner, Niklas" Date: Mon, 1 Jul 2024 16:23:45 +0200 Subject: [PATCH] Unminimize Event Details Dialog on update Fixes https://github.com/eclipse-platform/eclipse.platform.ui/issues/2019 When the Event Details Dialog is minimized it is brought back up when the user Double Clicks a new entry in the Error Log --- bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF | 2 +- .../ui/internal/views/log/EventDetailsDialogAction.java | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF index d9442d1705e..ebf2da6b7b4 100644 --- a/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF +++ b/bundles/org.eclipse.ui.views.log/META-INF/MANIFEST.MF @@ -2,7 +2,7 @@ Manifest-Version: 1.0 Bundle-ManifestVersion: 2 Bundle-Name: %name Bundle-SymbolicName: org.eclipse.ui.views.log;singleton:=true -Bundle-Version: 1.4.400.qualifier +Bundle-Version: 1.4.500.qualifier Bundle-Activator: org.eclipse.ui.internal.views.log.Activator Bundle-Vendor: %provider-name Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)", diff --git a/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/EventDetailsDialogAction.java b/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/EventDetailsDialogAction.java index cff3e23f4c5..200dc235dbd 100644 --- a/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/EventDetailsDialogAction.java +++ b/bundles/org.eclipse.ui.views.log/src/org/eclipse/ui/internal/views/log/EventDetailsDialogAction.java @@ -19,6 +19,7 @@ import org.eclipse.core.runtime.IAdaptable; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.swt.widgets.Control; +import org.eclipse.swt.widgets.Shell; import org.eclipse.ui.IMemento; import org.eclipse.ui.actions.SelectionProviderAction; @@ -88,6 +89,11 @@ public void setComparator(Comparator comparator) { public void run() { if (propertyDialog != null && propertyDialog.isOpen()) { resetSelection(); + Shell shell = propertyDialog.getShell(); + if (shell != null && shell.getMinimized()) { + shell.setMinimized(false); + } + return; }