Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick access twice the same entry #152

Open
vogella opened this issue Jun 17, 2022 · 3 comments
Open

Quick access twice the same entry #152

vogella opened this issue Jun 17, 2022 · 3 comments

Comments

@vogella
Copy link
Contributor

vogella commented Jun 17, 2022

image

@Bananeweizen as you recently worked on Quick access, do you also see this?
@mickaelistria
Copy link
Contributor

I also see it, but strangely, not as long as I type histo, but only when I add the r, and then adding the y removes the extra entry...

@Bananeweizen
Copy link
Contributor

The entries are added a second time, if you have previously selected the entry for the current input. I.e. a duplicate history entry for "hist" means that you selected it in a previous session after that input. If you now select the item after giving the input "histor", and restart eclipse then you get the duplicate entry for both "hist" and "histor". I'm still debugging...

Bananeweizen added a commit that referenced this issue Jun 17, 2022
@Bananeweizen
Avoid duplicate quick access entry (fixes #152)
4716ed2 
When you have used quick access previously, the dialog adds matching
entries from "previous" at the top. Afterwards the same entries may
appear from their "normal" provider (e.q. views, commands, ...).

Since the logic of adding entries seems quite complex, this change fixes
the duplicate entry by detecting the exact situation (same single entry
in first and second provider list), and then removes the duplicate entry
list.
Bananeweizen added a commit to Bananeweizen/eclipse.platform.ui that referenced this issue Jun 17, 2022
@Bananeweizen
Avoid duplicate quick access entry (fixes eclipse-platform#152)
090dfb3 
When you have used quick access previously, the dialog adds matching
entries from "previous" at the top. Afterwards the same entries may
appear from their "normal" provider (e.q. views, commands, ...).

Since the logic of adding entries seems quite complex, this change fixes
the duplicate entry by detecting the exact situation (same single entry
in first and second provider list), and then removes the duplicate entry
list.
@mickaelistria mickaelistria mentioned this issue Jun 18, 2022
Open
@mickaelistria
Copy link
Contributor

I think a more proper solution would be that items selected from the "Previous" category should not add themselves to the "previous" elements, but should instead "move up" the selected proposal in the existing previous list.

akurtakov pushed a commit to Bananeweizen/eclipse.platform.ui that referenced this issue Mar 20, 2024
@Bananeweizen @akurtakov
Avoid duplicate quick access entry (fixes eclipse-platform#152)
344f1d1 
When you have used quick access previously, the dialog adds matching
entries from "previous" at the top. Afterwards the same entries may
appear from their "normal" provider (e.q. views, commands, ...).

Since the logic of adding entries seems quite complex, this change fixes
the duplicate entry by detecting the exact situation (same single entry
in first and second provider list), and then removes the duplicate entry
list.
sDavydiuk pushed a commit to Halliburton-Landmark/eclipse.platform.ui that referenced this issue Jul 29, 2024
Avoid duplicate quick access entry
fd1dd27 
eclipse-platform/eclipse.platform.ui#152
@sDavydiuk sDavydiuk mentioned this issue Jul 29, 2024
Merged
ybova added a commit to Halliburton-Landmark/eclipse.platform.ui that referenced this issue Jul 30, 2024
@ybova
Merge pull request #47 from Halliburton-Landmark/find_actions_previou…
5262a97 
…s_entries_fix

Avoid duplicate quick access entry eclipse-platform/eclipse.platform.ui#152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vogella @Bananeweizen @mickaelistria