Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing theme of product doesn't work #185

Open
dhendriks opened this issue Jul 3, 2022 · 7 comments
Open

Changing theme of product doesn't work #185

dhendriks opened this issue Jul 3, 2022 · 7 comments

Comments

@dhendriks
Copy link
Contributor

I have an Eclipse product that is configured with a plugin_customization.ini. This file works, as there are many settings in there, that actually take effect. Now I'm trying to set the 'Light' theme, like this:

org.eclipse.e4.ui.css.swt.theme/themeid=org.eclipse.e4.ui.css.theme.e4_default

However, this doesn't work. I've traced this in the code to org.eclipse.e4.ui.css.swt.internal.theme.ThemeEngine.getPreferenceThemeId(), and this returns null rather than org.eclipse.e4.ui.css.theme.e4_default.

I've also tried:

  • Adding a cssTheme to my product extension: 
           <property
             name="cssTheme"
             value="org.eclipse.e4.ui.css.theme.e4_default">
       </property>
  • Specifying the theme on the command line:
    -cssTheme org.eclipse.e4.ui.css.theme.e4_default

None of it works.

I'm using Eclipse 2022-06.
@natarol
Copy link

natarol commented Jul 21, 2022 •
edited
Loading

Eclipse 2022-06 will determine the theme at startup according to the theme of the operating system, and this rule cannot be changed according to the configuration.

@vogella
Copy link
Contributor

vogella commented Aug 2, 2022

@dhendriks pull request to enable this configuration would be welcome

@dhendriks
Copy link
Contributor Author

@dhendriks pull request to enable this configuration would be welcome

See #300.

@dhendriks
Copy link
Contributor Author

dhendriks commented Sep 4, 2022 •
edited
Loading

@dhendriks pull request to enable this configuration would be welcome

See #300.

@vogella Could you review this?

@dhendriks
Copy link
Contributor Author

Is there any chance #300 can be included still in the 2022-09 release?

@iloveeclipse
Copy link
Member

Nope

akurtakov pushed a commit that referenced this issue Sep 6, 2022
@dhendriks @akurtakov
Add system property to override inheritance of OS dark theme. #185
f7af9f0 
- Still enabled by default, for backward compatibility.
- To disable, set the new property:
  org.eclipse.e4.ui.css.theme.disableOSDarkThemeInherit=true
akurtakov pushed a commit that referenced this issue Sep 6, 2022
@dhendriks @akurtakov
Dark theme inheritance override was a bit too much. #185
6953c7d 
- It would disable restoring the theme, even if not dark theme.
- Now only overrides the decision to inherit dark theme.
akurtakov pushed a commit that referenced this issue Sep 6, 2022
@dhendriks @akurtakov
Update plugin version for disableOSDarkThemeInherit change. #185
edb26d1
akurtakov pushed a commit that referenced this issue Sep 6, 2022
@dhendriks @akurtakov
Update plugin version qualifier to be multiple of 100. #185
ae7fa74
HannesWell pushed a commit to HannesWell/eclipse.platform.ui that referenced this issue Jul 1, 2023
@Christopher-Hermann
Use a custom ForkJoinWorkerThreadFactory in AsyncCompletionProposalPo…
783721b 
…pup (eclipse-platform#185)

* Use a custom ForkJoinWorkerThreadFactory in AsyncCompletionProposalPopup

CompletableFuture.supplyAsync() is using the defaultForkJoinWorkerThreadFactory. In case a SecurityManager is installed, using the defaultForkJoinWorkerThreadFactory would result in worker threads with no permissions, which leads to not content assist in the java editor.

Use a custom ForkJoinWorkerThreadFactory implementation to work around this.

See also:
eclipse-platform/eclipse.platform#294
eclipse-platform/eclipse.platform#295

* Improve comment
HannesWell pushed a commit to HannesWell/eclipse.platform.ui that referenced this issue Jul 1, 2023
@Christopher-Hermann @iloveeclipse
Revert "Use a custom ForkJoinWorkerThreadFactory in AsyncCompletionPr…
52976b6 
…oposalPopup (eclipse-platform#185)"

This reverts commit 783721b.
@Mailaender
Copy link

I can confirm that this is still a problem in Eclipse 2023-03.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@vogella @dhendriks @Mailaender @iloveeclipse @natarol