Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find/Replace overlay: Arrow button re-sizes on editor scrolling #2018

Closed
2 tasks done
Tracked by #2021
thomasritter opened this issue Jul 1, 2024 · 7 comments · Fixed by #2029
Closed
2 tasks done
Tracked by #2021

Find/Replace overlay: Arrow button re-sizes on editor scrolling #2018

thomasritter opened this issue Jul 1, 2024 · 7 comments · Fixed by #2029
Labels
bug Something isn't working

Comments

@thomasritter
Copy link

Let's make sure the issue is not already fixed in latest builds first.

Steps to reproduce

From a fresh installation and clean workspace:

  • Open an editor
  • Open find via cmd+f
  • Scroll the editor

I expected: The find UI control does not change on scrolling the editor

But got: The arrow buttons changes size. See GIF image

trimmed

Tested under this environment:

  • OS & version: Mac OS

Community

  • I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.
@thomasritter thomasritter added the bug Something isn't working label Jul 1, 2024
@Wittmaxi
Copy link

Wittmaxi commented Jul 1, 2024

@HeikoKlare can you please have a look at this? I don't have a way to test on mac and I can't reproduce this behavior on my setup.
It is possible that #2017 fixes this issue already

@Wittmaxi Wittmaxi mentioned this issue Jul 1, 2024
Open
67 tasks
@HeikoKlare
Copy link
Contributor

In my environment, the expand button does not change its size, but the find input field increases its size, so that the expand button is slightly moved to the left when scrolling. #2017 does not change anything with respect to that behavior.

@BeckerWdf
Copy link
Contributor

I think this only happens if you have the "sticky scrolling" activated.

@Wittmaxi
Copy link

Wittmaxi commented Jul 2, 2024

@Christopher-Hermann can you please check?

@Christopher-Hermann
Copy link
Contributor

Yes, I will take a look. But it will probably take some time

@thomasritter
Copy link
Author

thomasritter commented Jul 2, 2024 •
edited
Loading

I did another test round:

  • Only used JDT Java Editor
  • Switched off sticky scrolling
  • Tried with and without the breadcrumb (bug always happened)
  • Tried vertically and horizontal scrolling (bug always happened)

Same behavior. I do not think this is related to sticky scrolling.

I seems to me that any kind of redrawing the UI causes it to happen. For example, it also happens if I re-size the views or the Eclipse window.

@HeikoKlare HeikoKlare mentioned this issue Jul 4, 2024
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 4, 2024
@HeikoKlare
Improve styling of expand/collapse button in find/replace overlay ecl…
f2d30f4 
…ipse-platform#2018

The button for expanding the find/replace overlay to show the replace
bar it quite large on MacOS and also changes its size upon different
events, such activating options and scrolling in the editor target.

With this change, the button style is changed to "FLAT". It results in a
less space-consuming layout and fixes its size so that it does not
resize on events like scrolling in the target editor.

Fixes eclipse-platform#2018
@HeikoKlare HeikoKlare mentioned this issue Jul 4, 2024
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 4, 2024
@HeikoKlare
Improve styling of expand/collapse button in find/replace overlay ecl…
654f0d8 
…ipse-platform#2018

The button for expanding the find/replace overlay to show the replace
bar it quite large on MacOS and also changes its size upon different
events, such activating options and scrolling in the editor target.

With this change, the button style is changed to "FLAT". It results in a
less space-consuming layout and fixes its size so that it does not
resize on events like scrolling in the target editor.

Fixes eclipse-platform#2018
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 4, 2024
@HeikoKlare
Improve styling of expand/collapse button in find/replace overlay ecl…
1c8e8cb 
…ipse-platform#2018

The button for expanding the find/replace overlay to show the replace
bar it quite large on MacOS and also changes its size upon different
events, such activating options and scrolling in the editor target.

With this change, the button style is changed to "FLAT". It results in a
less space-consuming layout and fixes its size so that it does not
resize on events like scrolling in the target editor.

Fixes eclipse-platform#2018
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 5, 2024
@HeikoKlare
Improve styling of expand/collapse button in find/replace overlay ecl…
a5cfe91 
…ipse-platform#2018

The button for expanding the find/replace overlay to show the replace
bar it quite large on MacOS and also changes its size upon different
events, such activating options and scrolling in the editor target.

With this change, the button style is changed to "FLAT". It results in a
less space-consuming layout and fixes its size so that it does not
resize on events like scrolling in the target editor.

Fixes eclipse-platform#2018
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 7, 2024
@HeikoKlare
Improve styling of expand/collapse button in find/replace overlay ecl…
40702b0 
…ipse-platform#2018

The button for expanding the find/replace overlay to show the replace
bar it quite large on MacOS and also changes its size upon different
events, such activating options and scrolling in the editor target.

With this change, the button style is changed to "FLAT". It results in a
less space-consuming layout and fixes its size so that it does not
resize on events like scrolling in the target editor.

Fixes eclipse-platform#2018
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 7, 2024
@HeikoKlare
Improve styling of expand/collapse button in find/replace overlay ecl…
0b3229b 
…ipse-platform#2018

The button for expanding the find/replace overlay to show the replace
bar it quite large on MacOS and also changes its size upon different
events, such activating options and scrolling in the editor target.

With this change, the button style is changed to "FLAT". It results in a
less space-consuming layout and fixes its size so that it does not
resize on events like scrolling in the target editor.

Fixes eclipse-platform#2018
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 8, 2024
@HeikoKlare
Improve styling of expand/collapse button in find/replace overlay ecl…
332d60b 
…ipse-platform#2018

The button for expanding the find/replace overlay to show the replace
bar it quite large on MacOS and also changes its size upon different
events, such activating options and scrolling in the editor target.

With this change, the button style is changed to "FLAT". It results in a
less space-consuming layout and fixes its size so that it does not
resize on events like scrolling in the target editor.

Fixes eclipse-platform#2018
HeikoKlare added a commit that referenced this issue Jul 8, 2024
@HeikoKlare
Improve styling of expand/collapse button in find/replace overlay #2018
118f825 
The button for expanding the find/replace overlay to show the replace
bar it quite large on MacOS and also changes its size upon different
events, such activating options and scrolling in the editor target.

With this change, the button style is changed to "FLAT". It results in a
less space-consuming layout and fixes its size so that it does not
resize on events like scrolling in the target editor.

Fixes #2018
@thomasritter
Copy link
Author

Re-tested and looks good! Thanks for the fix Heiko :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
5 participants
@thomasritter @HeikoKlare @Wittmaxi @BeckerWdf @Christopher-Hermann