Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLS for "Enable theming" preference missing #2480

Closed
1 task done
HeikoKlare opened this issue Nov 1, 2024 · 1 comment · Fixed by #2481
Closed
1 task done

NLS for "Enable theming" preference missing #2480

HeikoKlare opened this issue Nov 1, 2024 · 1 comment · Fixed by #2481
Labels
bug Something isn't working

Comments

@HeikoKlare
Copy link
Contributor

Let's make sure issue is not already fixed in latest builds first.

Steps to reproduce

From a fresh installation and clean workspace:

  • open the preferences
  • go to General -> Appearance
  • see the first entry:
    {F854E0E3-03E5-44C2-8668-C57CFF0ADD56}

Here is some relevant log output

Warning: NLS missing message: ThemingEnabled in: org.eclipse.ui.internal.messages

Tested under this environment:

  • OS & version: Windows 11
  • Eclipse IDE/Platform version (as shown in Help > About): Eclipse SDK I20241031-1800

Reason

This is a regression from #2224
The messages file was changed, removing a necessary whitespace at the end of the line preceding the one with the missing NLS
{8EB93999-04D5-43CF-9159-AB7E730959BA}

Community

  • [x ] I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.
@HeikoKlare HeikoKlare added the bug Something isn't working label Nov 1, 2024
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Nov 1, 2024
@HeikoKlare
Fix missing NLS for "Enable theming" eclipse-platform#2480
d306aef 
The NLS for "Enable theming" is not found because of a recent change to
the according messages.properties file. This change reverts the faulty
change.

Fixes eclipse-platform#2480
@HeikoKlare HeikoKlare mentioned this issue Nov 1, 2024
Merged
@BeckerWdf
Copy link
Contributor

@HeikoKlare: Thanks for fixing.

mai-tran-03 pushed a commit to mai-tran-03/eclipse.platform.ui that referenced this issue Dec 10, 2024
@HeikoKlare @mai-tran-03
Fix missing NLS for "Enable theming" eclipse-platform#2480
0951077 
The NLS for "Enable theming" is not found because of a recent change to
the according messages.properties file. This change reverts the faulty
change.

Fixes eclipse-platform#2480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing NLS for "Enable theming" #2480 HeikoKlare/eclipse.platform.ui
2 participants
@HeikoKlare @BeckerWdf