The key binding shown hides cursor

[frankbenoit]

There are those settings in Preferences -> keys to show the key binding when command is invoked, by mouse and/or keyboard.
I find this very helpful when programming with shared screen.

However, when the cursor is at the end of the file, each keystroke (e.g. Ctrl Arrow left/right) brings up the window and it hides the cursor position. That is very annoying.
At would be helpful if that window is direct to another location when the focus is in text editor and the cursor at the bottom.

[mickaelistria]

Would you be interested in submitting a patch that fixes it? The relevant piece of code would be https://github.com/eclipse-platform/eclipse.platform.ui/blob/master/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/internal/keys/show/ShowKeysUI.java

[elsazac]

I had a look at this. getShell().getCaret() is giving me null and because of that I am unable to detect the overlap. Any suggestions ?

[BeckerWdf]

I think it would feel strange when the window showing the shortcut opens at different locations.

The window showing the shortcut has some transparency to mitigate the issue that it could overlap with some important part of the workbench. Maybe we could increase the transparency a bit more.

[elsazac]

I think it would feel strange when the window showing the shortcut opens at different locations.

The window showing the shortcut has some transparency to mitigate the issue that it could overlap with some important part of the workbench. Maybe we could increase the transparency a bit more.

@BeckerWdf Thanks for the suggestion. This looks reasonable to me.

@frankbenoit Are you ok with this approach? Let me know. If yes I will investigate on this.

[BeckerWdf]

@frankbenoit: Are you ok with the proposed change?

[frankbenoit]

Yes, if the editors writing/cursor is good readable this is fine.