Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase transparency of showKeyPopUp #1592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elsazac
Copy link
Member

@elsazac elsazac commented Jan 30, 2024

Fixes: #48

image

The text behind is partly visible now though at the expanse of transparency to the key shortcut text

@elsazac elsazac force-pushed the KeyBindHidesCursor branch from 4de4564 to d3f9759 Compare January 30, 2024 11:05
Copy link
Contributor

Test Results

   918 files  ±0     918 suites  ±0   47m 12s ⏱️ - 2m 15s
 7 439 tests ±0   7 286 ✅ ±0  152 💤 ±0  1 ❌ ±0 
23 466 runs  ±0  22 957 ✅ ±0  508 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit d3f9759. ± Comparison against base commit f0b1071.

@laeubi
Copy link
Contributor

laeubi commented Jan 30, 2024

Please also test with a light theme / background ...

@BeckerWdf
Copy link
Contributor

Please also test with a light theme / background ...

I did. In the light theme it also works fine - maybe even better...

@elsazac
Copy link
Member Author

elsazac commented Jan 30, 2024

Please also test with a light theme / background ...

image

This is the appearance in light theme.Does this look good?

@BeckerWdf
Copy link
Contributor

image

@laeubi
Copy link
Contributor

laeubi commented Jan 30, 2024

It is a bit hard to tell, but can we make the background only transparent but the text opaque.... the screen looks like underlying text is shining though the text what makes it very hard to read.

@laeubi
Copy link
Contributor

laeubi commented Jan 30, 2024

image

I find the text underneath (Moves the ...) hardly readable now if I wouldn't know what is supposed to be there...

@elsazac
Copy link
Member Author

elsazac commented Jan 31, 2024

I find the text underneath (Moves the ...) hardly readable now if I wouldn't know what is supposed to be there...

@laeubi For some reason I can't see the picture you posted.

@laeubi
Copy link
Contributor

laeubi commented Jan 31, 2024

It is from this comment #1592 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The key binding shown hides cursor
3 participants