-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase transparency of showKeyPopUp #1592
base: master
Are you sure you want to change the base?
Conversation
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/show/ShowKeysUI.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/show/ShowKeysUI.java
Outdated
Show resolved
Hide resolved
4de4564
to
d3f9759
Compare
Test Results 918 files ±0 918 suites ±0 47m 12s ⏱️ - 2m 15s For more details on these failures, see this check. Results for commit d3f9759. ± Comparison against base commit f0b1071. |
Please also test with a light theme / background ... |
I did. In the light theme it also works fine - maybe even better... |
It is a bit hard to tell, but can we make the background only transparent but the text opaque.... the screen looks like underlying text is shining though the text what makes it very hard to read. |
@laeubi For some reason I can't see the picture you posted. |
It is from this comment #1592 (comment) |
Fixes: #48
The text behind is partly visible now though at the expanse of transparency to the key shortcut text