Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to parameterize preference section of the theme css #82

Open
gayanper opened this issue May 21, 2022 · 1 comment
Open

Add support to parameterize preference section of the theme css #82

gayanper opened this issue May 21, 2022 · 1 comment

Comments

@gayanper
Copy link
Contributor

gayanper commented May 21, 2022 •
edited
Loading

Suggestion

As a starting point to implement some similar to described in https://twitter.com/gaparv/status/1527965482158112769?s=21&t=nJqrxHjxvqwDdx6xn3PjYQ We should have the support to parameterized as many values in the current theme definitions.

The idea is to parameterize things like

  • view background / foreground
  • editor group background / foreground
  • editor background / foreground
  • editor selection background / foreground
  • editor popup background / foreground

Benefits

This will enable us to have more platform level themes definitions for light and dark and let theme developers to customize them based on the parameters.

This will also enable to easily fix styling issues where most of the themes will adapt without any changes in most of the scenarios.

The effort to create a new theme will be less.
@gayanper
Copy link
Contributor Author

@vogella @mickaelistria What do you think about this idea ?

HannesWell pushed a commit to HannesWell/eclipse.platform.ui that referenced this issue Jul 1, 2023
@jukzi
fix StringIndexOutOfBoundsException during File Search eclipse-platfo…
f2f673b 
…rm#79 (eclipse-platform#82)

If same search is started in parallel.
java.util.regex.Matcher is not thread-safe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gayanper