Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbuilt support for content assist on typing like vscode #888

Open
gayanper opened this issue Jun 7, 2022 · 3 comments
Open

Inbuilt support for content assist on typing like vscode #888

gayanper opened this issue Jun 7, 2022 · 3 comments

Comments

@gayanper
Copy link
Contributor

gayanper commented Jun 7, 2022

Today for JavaEditor we can achieve this my providing all the letters in the activation trigger. But the experience is not so good due to auto activation doesn't debounce the key events. For example when you are trying continuously we don't want to content assist to popup and preselect wrong suggestions which the developer doesn't need.

The current activation logic can be extended to support debounce, We could introduce a configuration to enable this new activation feature for all valid keys with debounce. One simple implementation would be to change the current activation logic by resetting the last activation time when ever a key is pressed and reduce the delay to something like 100ms in this new mode.

@gayanper
Copy link
Contributor Author

gayanper commented Jun 7, 2022

@mickaelistria @vogella Do you think this is a good idea, if so I can try out and push a PR

@mickaelistria
Copy link
Contributor

Yes, it's a good idea that was tracked in https://bugs.eclipse.org/bugs/show_bug.cgi?id=101420 . I suggest you look into the comments and blockers in more details before going too deep. It's not as easy as it seems in the current state and we'll probably need preliminary fixes in JDT or other before this can be achieve smoothly.

@mickaelistria
Copy link
Contributor

See also eclipse-platform/eclipse.platform.text#66 which enables it by default in generic editor. It's very nice to use!

@laeubi laeubi transferred this issue from eclipse-platform/eclipse.platform.text Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants