Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Mining: code mining background should not remain unchanged when selected #94

Open
humphreygao opened this issue Jun 6, 2022 · 1 comment

Comments

@humphreygao
Copy link

image

image

@mickaelistria
Copy link
Contributor

I've a patch that implements it at https://github.com/mickaelistria/eclipse.platform.swt/pull/new/selection-bg-codemining .
However, the selection background in Eclipse IDE which is inherited for the OS (Fedora in my case) is a darker blue and makes reading codemining impossible. So if we want to adopt it, then we need also to adapt the code that draws the code minings so it changes color when selecting the right parts of the line. It all becomes trickier and this is not critical enough to me; so I'm giving up on this topic for the moment to focus on more important bits. Maybe later, probably never ;) But if anyone else wants to work on it, they're more than welcome to take the patch above as a starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants