Allow adding variant via prompttemplate files #14509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed #14507 Signed-off-by: Jonas Helming <[email protected]>
sdirix
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Works for me!
I tested editing the workspace agent template. Creating a new template and setting it in the AI configuration works fine.
There are some glitches when deleting this file:
- Create this custom variant template
- Set it in the UI for an agent
- Send a request for the agent, observe it is correctly set as system prompt
If the file is now deleted, the following happens:
- It's still shown in the AI configuration UI until the selection is switched back and forth
- Although it's gone, clicking on "Edit" will still open an editor for the no longer existing file
- When sending a request to the agent, it will use NO system prompt
What is likely going on is that, although deleted, Theia AI still tries to use the deleted prompt variant. In the UI this leads to the variant no longer appearing in the dropdown, but still being selected. At request time, the prompt can't be found and then no prompt is used.
This use case should be handled cleaner:
- The UI should be updated immediately
- The Edit button should always open the correct file
- Requests should fallback to their regular prompt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #14507
What it does
Allows users to add custom variants to existing main prompts via adding .prompttemplate files.
If the file name of a .prompttemplate file starts with the id of an existing main prompt, the custom prompt file is treated as a variant.
How to test
Follow-ups
we might allow users to create variants in the UI
Review checklist
Reminder for reviewers