chore(CxMembership): Set Catena-X Membership in BPDM #1118
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/registration/ApplicationActivation.Library/ApplicationActivationService.cs
Fixed
Show fixed
Hide fixed
tfjanjua
force-pushed
the
chore/1111-Set-Catena-X-Membership-in-BPDM
branch
from
05892e0
to
508af80
Compare
ntruchsess
force-pushed
the
chore/1111-Set-Catena-X-Membership-in-BPDM
branch
from
8a0304f
to
c649d4d
Compare
|
There was a problem hiding this comment.
@tfjanjua : I did fix a few findings and force-pushed to your repo after rebasing on latest main. Please pull he changes before proceeding. (And also have a look on what I changed to avoid such findings in the future).
PR currently cannot be merged as the configuration in portal-repo does not match. Also we need to come up with a better approach to handle multiple bpdm deployments without hardcoding the fact that this particular call is different into the service-method.
|
|
||
| // Same User (which we have for BPDM service) can be used to call Business Partner Pool | ||
| // But BaseAddress of Business Partner Pool is different as its deployed on another server. | ||
| httpClient.BaseAddress = new Uri(_settings.BusinessPartnerPoolBaseAddress); |
There was a problem hiding this comment.
(while technically working) this is not how a httpClientFactory (which is used in tokenService) should be used. The service-code should not have to deal with the baseAddress.
Thank you @ntruchsess , providing your feedback. I've looked at your commit and found some formatting and addition of license related information (especially in migration files). I'll have a look at configuration PR. |
Description
Set Catena-X Membership in BPDM.
Why
As Portal, we would like to maintain a list of all companies that were onboarded to the Catena-X network. This membership information is meant to be stored in the BPDM Pool. We therefore need to update the
isCatenaXMemberflag for a BPNL once the company has been onboarded.Issue
Ref: #1111
Config PR: eclipse-tractusx/portal#472
BPDM PR: eclipse-tractusx/bpdm#1072
Checklist