Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSP | Regex validation needs to be applied #1157

Open
tfjanjua opened this issue Nov 18, 2024 · 0 comments · May be fixed by #1163
Open

OSP | Regex validation needs to be applied #1157

tfjanjua opened this issue Nov 18, 2024 · 0 comments · May be fixed by #1163
Assignees
Labels
bug Something isn't working

Comments

@tfjanjua
Copy link
Contributor

Current Behavior

Currently, request is being validated with invalid data e.g: "VAT ID" --> “value“ : “XYZ“

image

and system is validating and processing the company with invalid vat id : “XYZ“

image

image

Expected Behavior

Ideally, validation should be applied on the endpoint: api/administration/registration/Network/partnerRegistration

Steps To Reproduce

  1. Register a tenant via endpoint api/administration/registration/Network/partnerRegistration
  2. Add invalid data e.g: VAT ID --> “value“ : “XYZ“
  3. Send request
  4. Configure everything for authentication --> Redirect URI
  5. Open the Welcome email --> click on “Complete registration“
  6. Login via portal --> search for recent created tenant
  7. Inspect and check “Company details“ endpoint in the network tab
  8. Check VAT ID
  9. Submit the form
@tfjanjua tfjanjua added the bug Something isn't working label Nov 18, 2024
@tfjanjua tfjanjua self-assigned this Nov 18, 2024
@tfjanjua tfjanjua added this to Portal Nov 18, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Nov 18, 2024
@tfjanjua tfjanjua moved this from NEW USER REQUEST to IN PROGRESS in Portal Nov 18, 2024
@tfjanjua tfjanjua linked a pull request Nov 19, 2024 that will close this issue
6 tasks
@tfjanjua tfjanjua moved this from IN PROGRESS to IN REVIEW in Portal Nov 19, 2024
@ntruchsess ntruchsess linked a pull request Nov 19, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: IN REVIEW
Development

Successfully merging a pull request may close this issue.

1 participant