-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"+" and "=" characters are not allowed in Value field of SpecificAsset Ids while creating Submodel description using DTR #391
Comments
We have a fix within Cofinity-X we'll open PR in a moment. |
@tunacicek @thomas-henn for reference. |
PR #392 will fix this issue |
Only being the messenger here but the IDTA does not want this to be "fixed" as it's actually a feature and not a bug. It's apparently due to compatibility reasons with XML. @thomas-henn can provide further insights. |
This RegEx in sldt-digital-twin-registry/backend/src/main/resources/static/aas-registry-openapi.yaml Line 1483 in 7f1937d
corresponds to the permitted strings in XML Schema 1.0 to enable conversions between different formats (see constraint AASd-130 in the metamodel IDTA-01001-3-0). This restriction was intensively discussed for AAS API V3.1. The result was that it should stay that way. Please create a corresponding issue for this in https://github.com/admin-shell-io/aas-specs. Would a base64 encoding of the VAN help to overcome this conformant to IDTA standards? |
un-assigning myself as I am unable to provide substantial input on what typical naming schemes for digital twins are within Catena-X. I am aware of the "+" and "=" often used in naming schemes as stated in this issue. I can not give insight on whether naming schemes must include a VIN / anonymized VIN . Base64 includes "+" as character 62 and "=" as padding. |
The issue is created in admin shell.io repository. Here is the link: admin-shell-io/aas-specs#410 |
this is the regex required for all string attributes in the AAS 3.0 (Constraint AASd-130) It includes + and =. please fix the regex in your implementation see also admin-shell-io/aas-specs#362 |
Current Behavior
If we use special characters like + and = while creating submodel descriptor then it gives 400 error.
Expected Behavior
Few Special characters like + and = should be allowed if a business partner don't want to store the actual value in specific Ids and wants to store in encoded format then it should work.
Steps To Reproduce
In POST API for creating shell and as value in specificAssetIds provide value with these special character.
The text was updated successfully, but these errors were encountered: