Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"+" and "=" characters are not allowed in Value field of SpecificAsset Ids while creating Submodel description using DTR #391

Open
richaashara opened this issue Apr 9, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@richaashara
Copy link

Current Behavior

If we use special characters like + and = while creating submodel descriptor then it gives 400 error.

Expected Behavior

Few Special characters like + and = should be allowed if a business partner don't want to store the actual value in specific Ids and wants to store in encoded format then it should work.

Steps To Reproduce

In POST API for creating shell and as value in specificAssetIds provide value with these special character.

@richaashara richaashara added the bug Something isn't working label Apr 9, 2024
@drhansbeck drhansbeck self-assigned this Apr 9, 2024
@drhansbeck
Copy link

We have a fix within Cofinity-X we'll open PR in a moment.

@gerbigf
Copy link

gerbigf commented Apr 9, 2024

@tunacicek @thomas-henn for reference.

@richaashara
Copy link
Author

PR #392 will fix this issue

@gerbigf
Copy link

gerbigf commented Apr 10, 2024

Only being the messenger here but the IDTA does not want this to be "fixed" as it's actually a feature and not a bug. It's apparently due to compatibility reasons with XML. @thomas-henn can provide further insights.

@thomas-henn
Copy link

This RegEx in

pattern: "^([\\t\\n\\r \\_\\.\\/\\:\\#\\-a-zA-Z0-9]|[\\ud800\\udc00-\\ud800\\udfff]|[\\ud801\\udc00-\\udbfe\\udfff]|[\\udbff\\udc00-\\udbff\\udfff])*+$"

corresponds to the permitted strings in XML Schema 1.0 to enable conversions between different formats (see constraint AASd-130 in the metamodel IDTA-01001-3-0). This restriction was intensively discussed for AAS API V3.1. The result was that it should stay that way.

Please create a corresponding issue for this in https://github.com/admin-shell-io/aas-specs.

Would a base64 encoding of the VAN help to overcome this conformant to IDTA standards?

@drhansbeck
Copy link

un-assigning myself as I am unable to provide substantial input on what typical naming schemes for digital twins are within Catena-X. I am aware of the "+" and "=" often used in naming schemes as stated in this issue. I can not give insight on whether naming schemes must include a VIN / anonymized VIN .

Base64 includes "+" as character 62 and "=" as padding.
https://en.wikipedia.org/wiki/Base64

@richaashara
Copy link
Author

richaashara commented Apr 16, 2024

@thomas-henn , @drhansbeck ,

The issue is created in admin shell.io repository. Here is the link: admin-shell-io/aas-specs#410

@BirgitBoss
Copy link

"^([\\t\\n\\r-\\ud7ff\\ue000-\\ufffd]|\\ud800[\\udc00-\\udfff]|[\\ud801-\\udbfe][\\udc00-\\udfff]|\\udbff[\\udc00-\\udfff])*$"

this is the regex required for all string attributes in the AAS 3.0 (Constraint AASd-130) It includes + and =.

please fix the regex in your implementation

see also admin-shell-io/aas-specs#362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants