Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kuksa.val and VSC references #128

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Remove kuksa.val and VSC references #128

merged 2 commits into from
Sep 12, 2024

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented Jul 24, 2024 •
edited
Loading

This PR intends to do these things

  • Replace the term "kuksa.val" with "kuksa"
  • Remove references to old kuksa.val repositories
  • Remove references to COVESA VSC as that project is dormant. COVESA has an IFEX project (which has taken over the VSC syntax but not the catalog) but Velocitas does not really have any connection to that
  • Also doing some minor updates to workflows to make it more visible what they actually do.

@erikbosch erikbosch marked this pull request as ready for review July 24, 2024 07:42
BjoernAtBosch
BjoernAtBosch reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First findings

content/en/docs/concepts/development_model/_index.md Show resolved Hide resolved
content/en/docs/concepts/development_model/vehicle_app_sdk/_index.md Outdated Show resolved Hide resolved
content/en/docs/concepts/development_model/val/_index.md Show resolved Hide resolved
@erikbosch
Copy link
Contributor Author

@BjoernAtBosch @lukasmittag - I have addressed the comments but also detect a few oddities.

  • We have a workflow called CI but it only runs on merge
  • We publish to "official documentation" only when running manual
  • I do not really understand why we publish to two branches

I did some minor improvements to build scripts, but it should not affect anything practical.

BjoernAtBosch
BjoernAtBosch approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikbosch erikbosch merged commit e8ca8f3 into eclipse-velocitas:main Sep 12, 2024
2 checks passed
@erikbosch erikbosch deleted the erik-kuksaval branch September 12, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BjoernAtBosch BjoernAtBosch BjoernAtBosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikbosch @BjoernAtBosch