-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve service documentation #129
Improve service documentation #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check if you could move some general concepts to the title page to not copy'n'paste the same content on 2 pages. The definition of address/port comes to my mind e.g.
content/en/docs/tutorials/grpc_service_generation/create_client.md
Outdated
Show resolved
Hide resolved
content/en/docs/tutorials/grpc_service_generation/create_server.md
Outdated
Show resolved
Hide resolved
content/en/docs/tutorials/grpc_service_generation/create_server.md
Outdated
Show resolved
Hide resolved
content/en/docs/tutorials/grpc_service_generation/create_server.md
Outdated
Show resolved
Hide resolved
content/en/docs/tutorials/grpc_service_generation/create_server.md
Outdated
Show resolved
Hide resolved
Also some changes needed to make devcontainer work
d3f4fa4
to
3ad123e
Compare
I wanted to let
I think it has a value that the client/server pages are quite independent, and the environment variables you need to set varies partially. |
content/en/docs/tutorials/grpc_service_generation/create_server.md
Outdated
Show resolved
Hide resolved
content/en/docs/tutorials/grpc_service_generation/create_server.md
Outdated
Show resolved
Hide resolved
content/en/docs/tutorials/grpc_service_generation/create_server.md
Outdated
Show resolved
Hide resolved
content/en/docs/tutorials/grpc_service_generation/create_server.md
Outdated
Show resolved
Hide resolved
(Includes comments until about 09.00 CEST)
content/en/docs/tutorials/grpc_service_generation/create_client.md
Outdated
Show resolved
Hide resolved
content/en/docs/tutorials/grpc_service_generation/create_client.md
Outdated
Show resolved
Hide resolved
content/en/docs/tutorials/grpc_service_generation/create_client.md
Outdated
Show resolved
Hide resolved
content/en/docs/tutorials/grpc_service_generation/create_server.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Markus Petke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Only merge after the SDK PR is merged
Describe your changes
This originates from that I found the current documentation somewhat limited. What I have done:
Please visit https://erikbosch.github.io/velocitas-docs/ for a rendered version after changes applied
Issue ticket number and link
Checklist before requesting a review