Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt more links #3270

Merged
merged 2 commits into from
Nov 30, 2024
Merged

adapt more links #3270

merged 2 commits into from
Nov 30, 2024

Conversation

cdietrich
Copy link
Contributor

No description provided.

Signed-off-by: Christian Dietrich <[email protected]>
<connection>scm:git:https://github.com/eclipse/xtext-xtend.git</connection>
<developerConnection>scm:git:https://github.com/eclipse/xtext-xtend.git</developerConnection>
<url>https://github.com/eclipse/xtext-xtend.git</url>
<connection>scm:git:https://github.com/eclipse-xtext/xtext.git</connection>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 3 elements are not required: they are inherited from the parent pom.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the 3 XML tags you modified

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmhave no longer pc Access can you adjust? We did we have 3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that tomorrow, but I don't understand your answer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have this thing 3 times. why.
i overlooked the dev bom in the other pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the dev bom is ok: that doesn't inherit from the parent pom.

Copy link

github-actions bot commented Nov 28, 2024

Test Results

  6 460 files    6 460 suites   3h 14m 8s ⏱️
 43 238 tests  42 654 ✅   584 💤  0 ❌
170 253 runs  167 904 ✅ 2 336 💤 13 ❌

Results for commit 2f8d058.

♻️ This comment has been updated with latest results.

@LorenzoBettini
Copy link
Contributor

@cdietrich I made the changes, removing the XML sections and I also fixed the URL of the Xtend website

@cdietrich cdietrich merged commit 5efcdea into main Nov 30, 2024
16 of 17 checks passed
@cdietrich cdietrich deleted the cd-more-scms branch November 30, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants