Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Protobuf integration in examples #295

Open
yellowhatter opened this issue Nov 29, 2024 · 1 comment
Open

[Bug] Protobuf integration in examples #295

yellowhatter opened this issue Nov 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@yellowhatter
Copy link
Contributor

Describe the bug

Protobuf keeps breaking CMake scripts from time to time. Need to figure out more or less stable approach to integrate it. Maybe conan? Or build it's exact version from source in the example directory?

To reproduce

System info

@yellowhatter yellowhatter added the bug Something isn't working label Nov 29, 2024
@cvilas
Copy link

cvilas commented Nov 29, 2024

The right approach might be to eliminate protobuf from this repository completely. After all it is a third-party dependency Zenoh developers have no control over. Since Zenoh just transports bytes and is independent of any serialisation framework, why even carry the burden, and make undesirable compromises to make it work? Protobuf adds little to no value in this repo itself. Leave it to the user to integrate it into their application as they please.

Please don't force a package manager on us users though. CMake is good and has to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants