Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid magic numbers in the Config #1614

Open
yellowhatter opened this issue Nov 27, 2024 · 0 comments
Open

Avoid magic numbers in the Config #1614

yellowhatter opened this issue Nov 27, 2024 · 0 comments
Assignees
Labels
new feature Something new is needed

Comments

@yellowhatter
Copy link
Contributor

Describe the feature

There are magic numbers in our Config, like -1 for various timeouts:

wait_before_drop: i64,

fn duration_from_i64us(us: i64) -> Duration {

That is an awful, implicit, and non-documented way of configuring infinite duration (@Mallets )

This issue is about reviewing and removing magic numbers from the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Something new is needed
Projects
None yet
Development

No branches or pull requests

1 participant