Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default config listen endpoints when transport_tcp feature is disabled #1623

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

OlivierHecart
Copy link
Contributor

When transport_tcp feature is enabled, default listen endpoints are (as before) :

{
    router: ["tcp/[::]:7447"],
    peer: ["tcp/[::]:0"],
    client: [],
}

When transport_tcp feature is disabled, default listen endpoints are (now) :

{
    router: [],
    peer: [],
    client: [],
}

This avoids having this error: Unsupported protocol: tcp. when running a router or peer build with transport_tcp feature disabled and the default config.

@OlivierHecart OlivierHecart added the enhancement Existing things could work better label Dec 2, 2024
@OlivierHecart OlivierHecart linked an issue Dec 2, 2024 that may be closed by this pull request
@YuanYuYuan
Copy link
Contributor

YuanYuYuan commented Dec 2, 2024

LGTM. Thanks @OlivierHecart. This would fix #1572

@Mallets
Copy link
Member

Mallets commented Dec 2, 2024

The proposed changes LGTM. However, a warning should be added in the orchestrator code if the listen endpoints are empty when operating in a peer/router mode. This would provide some additional information to the user that the peer/router are working as expected.

@Mallets Mallets enabled auto-merge December 3, 2024 14:49
@Mallets Mallets merged commit 9a73585 into main Dec 3, 2024
23 checks passed
@OlivierHecart OlivierHecart deleted the dev/default_endpoints branch December 4, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The default endpoints to listen on
3 participants