Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for checking markdown format. #1662

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

evshary
Copy link
Contributor

@evshary evshary commented Dec 12, 2024

The README format is sometimes not well-formatted. Add CI to make sure this can be checked automatically.
For vscode developer, installing markdownlint plugin can provide the lint warning.

Copy link

PR missing one of the required labels: {'dependencies', 'enhancement', 'bug', 'documentation', 'new feature', 'internal', 'breaking-change'}

@evshary evshary added the internal Changes not included in the changelog label Dec 12, 2024
@evshary
Copy link
Contributor Author

evshary commented Dec 12, 2024

@Mallets do you think it's worth adding the markdown CI check here? If yes, I can apply it to all other repos

@evshary evshary requested a review from Mallets December 12, 2024 06:54
@Mallets
Copy link
Member

Mallets commented Dec 12, 2024

I think it's good to have the check enabled in the CI.

@Mallets Mallets merged commit 8716c87 into eclipse-zenoh:main Dec 12, 2024
14 of 15 checks passed
@evshary evshary deleted the check_markdown branch December 13, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants