Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTBFS with Node.js 12: error: no matching function for call to ‘v8::Value::ToObject()’ #692

Open
thiagomacieira opened this issue Nov 11, 2019 · 2 comments

Comments

@thiagomacieira
Copy link

make[2]: Entering directory '/builddir/build/BUILD/upm-2.0.0/clr-build'
/builddir/build/BUILD/upm-2.0.0/clr-build/interfaces/CMakeFiles/jsupm_interfaces.dir/interfacesJAVASCRIPT_wrap.cxx: In function ‘int SWIG_V8_GetInstancePtr(v8::Handle<v8::Value>, void**)’:
/builddir/build/BUILD/upm-2.0.0/clr-build/interfaces/CMakeFiles/jsupm_interfaces.dir/interfacesJAVASCRIPT_wrap.cxx:1030:52: error: no matching function for call to ‘v8::Value::ToObject()’
 1030 |   v8::Handle<v8::Object> objRef = valRef->ToObject();
      |                                                    ^
In file included from /usr/include/node/node.h:63,
                 from /builddir/build/BUILD/upm-2.0.0/clr-build/interfaces/CMakeFiles/jsupm_interfaces.dir/interfacesJAVASCRIPT_wrap.cxx:171:
/usr/include/node/v8.h:2576:44: note: candidate: ‘v8::MaybeLocal<v8::Object> v8::Value::ToObject(v8::Local<v8::Context>) const’
 2576 |   V8_WARN_UNUSED_RESULT MaybeLocal<Object> ToObject(
      |                                            ^~~~~~~~
/usr/include/node/v8.h:2576:44: note:   candidate expects 1 argument, 0 provided
In file included from /usr/include/node/v8-internal.h:14,
                 from /usr/include/node/v8.h:25,
                 from /usr/include/node/node.h:63,
                 from /builddir/build/BUILD/upm-2.0.0/clr-build/interfaces/CMakeFiles/jsupm_interfaces.dir/interfacesJAVASCRIPT_wrap.cxx:171:
/usr/include/node/v8.h:2590:31: note: candidate: ‘v8::Local<v8::Object> v8::Value::ToObject(v8::Isolate*) const’
 2590 |                 Local<Object> ToObject(Isolate* isolate) const);
      |                               ^~~~~~~~
/usr/include/node/v8config.h:318:44: note: in definition of macro ‘V8_DEPRECATED’
  318 | #define V8_DEPRECATED(message, declarator) declarator
      |                                            ^~~~~~~~~~
/usr/include/node/v8.h:2590:31: note:   candidate expects 1 argument, 0 provided
 2590 |                 Local<Object> ToObject(Isolate* isolate) const);
      |                               ^~~~~~~~

Node.js 12.13.0

@Propanu Propanu changed the title FTBFS with Noje.js 12: error: no matching function for call to ‘v8::Value::ToObject()’ FTBFS with Node.js 12: error: no matching function for call to ‘v8::Value::ToObject()’ Nov 11, 2019
@Propanu
Copy link
Contributor

Propanu commented Nov 11, 2019

Hi @thiagomacieira this is due to SWIG not having Node.js 12 support released yet. There have been some developments on it though, they can be followed here. Seems like there's a good chance this will get fixed with SWIG 4.1 since one of the project contributors has a working patch.

@lissyx
Copy link

lissyx commented Nov 12, 2019

Hi @thiagomacieira this is due to SWIG not having Node.js 12 support released yet. There have been some developments on it though, they can be followed here. Seems like there's a good chance this will get fixed with SWIG 4.1 since one of the project contributors has a working patch.

Just to make it clear, I shared my changes in the hope that someone picks up on that and finished properly a PR. But I honestly don't have enough time to do that, not in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants