Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interactions] Support Context Menus in Diagrams #29

Open
CamilleLetavernier opened this issue Jan 18, 2019 · 1 comment
Open

[Interactions] Support Context Menus in Diagrams #29

CamilleLetavernier opened this issue Jan 18, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@CamilleLetavernier
Copy link
Collaborator

We currently can't open a context menu in a GEFx Diagram. We should implement this.

There are a few options for this:

  • Use the Eclipse Context Menus (Via the Eclipse Menu Service), and open an SWT Menu on top of the Diagram. This would be the simplest solution
  • Use the Eclipse Menu Service with a custom (JavaFX) menu. This would be more portable. However, JavaFX Context Menus in an FXCanvas don't work on Linux (Plain JavaFX Context Menus work fine, and FX-in-SWT ContextMenus work fine on other platforms as well)

We could also go for a complete custom approach, or hide the Eclipse Menu Service behind our own API to allow deployment outside of Eclipse (But in general we want to reuse the Eclipse capabilities for defining menus, so we'll probably still rely on the Eclipse Menu Service)

@CamilleLetavernier CamilleLetavernier added the enhancement New feature or request label Jan 18, 2019
@mwienand
Copy link

FWIW, we plan to provide context menu abstractions for GEF as well: https://bugs.eclipse.org/bugs/show_bug.cgi?id=508985

If you have any input w.r.t. a desirable solution, feel free to let us know :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants