Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interactions] Fix Marquee Selection: Diagram Content Part shouldn't be included in the selection #33

Open
CamilleLetavernier opened this issue Jan 22, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@CamilleLetavernier
Copy link
Collaborator

Our custom MarqueeOnDragHandler extends the GEF one (org.eclipse.gef.mvc.fx.handlers.MarqueeOnDragHandler), but is not 100% compatible with it. Especially, we don't support empty selection in Papyrus (We always select the diagram content part if there is no other selection). However, GEF's MarqueeOnDragHandler (And especially SelectionOperation) always prepends the selection to whatever is already selected (i.e. at least the diagram part in our case).

As a result, when we use Marquee Selection, we always get the selected parts + the diagram content part (Instead of just the selected parts, or the diagram content parts if nothing is touched by the marquee selection area)

To reproduce:

  • Use marquee selection on any node(s)
  • Check the properties view: the covered node(s) is selected, as well as the diagram content part

Expected behavior:

  • Only the parts inside the marquee selection area are selected (Excluding the diagram content part)
  • If (and only if) the marquee selection area is empty, only the diagram content part is selected
@CamilleLetavernier CamilleLetavernier added the bug Something isn't working label Jan 22, 2019
@CamilleLetavernier CamilleLetavernier changed the title [Interactions] Fix Marquee Selection [Interactions] Fix Marquee Selection: Diagram Content Part shouldn't be included in the selection Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant