Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of undefined locations #16

Open
romainsacchi opened this issue May 7, 2024 · 4 comments
Open

List of undefined locations #16

romainsacchi opened this issue May 7, 2024 · 4 comments

Comments

@romainsacchi
Copy link
Contributor

List of locations that are currently undefined:

  • RoE

leading to:

File [/opt/homebrew/Caskroom/miniforge/base/envs/premise/lib/python3.11/site-packages/constructive_geometries/geomatcher.py:81](http://localhost:8888/opt/homebrew/Caskroom/miniforge/base/envs/premise/lib/python3.11/site-packages/constructive_geometries/geomatcher.py#line=80), in Geomatcher.__getitem__(self, key)
     79 if key == "RoW" and "RoW" not in self.topology:
     80     return set()
---> 81 return self.topology[self._actual_key(key)]

File [/opt/homebrew/Caskroom/miniforge/base/envs/premise/lib/python3.11/site-packages/constructive_geometries/geomatcher.py:114](http://localhost:8888/opt/homebrew/Caskroom/miniforge/base/envs/premise/lib/python3.11/site-packages/constructive_geometries/geomatcher.py#line=113), in Geomatcher._actual_key(self, key)
    111             print("Geomatcher: Used '{}' for '{}'".format(new, key))
    112         return new
--> 114 raise KeyError("Can't find location: {}.".format(key))

KeyError: "Can't find location: RoE."
@romainsacchi
Copy link
Contributor Author

@cmutel

@romainsacchi
Copy link
Contributor Author

Hi @cmutel, if you can give me a hint on how to fix that, I can give it a try.

@romainsacchi
Copy link
Contributor Author

Hey @cmutel, please try to fix that one before October. It's a bit of a blocker for me.

@cmutel
Copy link
Contributor

cmutel commented Sep 17, 2024

Fixed in cmutel@1f1a74e, released in 1.0.

Note that RoE is a dynamic location and is therefore not normally included in the topology. To add it you need to use the resolved_roe decorator. This is the same behaviour as RoW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants