Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supprimer le warning du DsfrNavigationMenuLink.vue #488

Open
abulte opened this issue Nov 25, 2024 · 2 comments
Open

Supprimer le warning du DsfrNavigationMenuLink.vue #488

abulte opened this issue Nov 25, 2024 · 2 comments
Assignees
Labels
bug Something isn't working dev

Comments

@abulte
Copy link

abulte commented Nov 25, 2024

Cf https://ecosphres.slack.com/archives/C07KNCLLEJW/p1732010068316749

Investiguer sur la cause de cette issue pour cleaner la console.
Si besoin contacter les dév du composant DSFR.

--> Update 19/01 : Todo : suite aux investigations, il est nécessaire de reprendre l'implémentation en respectant les bonnes pratiques vue-DSFR

@abulte abulte added dev to refine Tickets à présenter en refinement. Retirer le label une fois le ticket passé en backlog ready labels Nov 25, 2024
@abulte abulte moved this to To Do in Ecosphères Nov 25, 2024
@DanFluture275 DanFluture275 removed the to refine Tickets à présenter en refinement. Retirer le label une fois le ticket passé en backlog ready label Nov 27, 2024
@narduin
Copy link

narduin commented Dec 3, 2024

J'ai rejoint le discord et j'ai posé la question !

@narduin narduin moved this from To Do to 💤 Blocked in Ecosphères Dec 3, 2024
@narduin
Copy link

narduin commented Dec 9, 2024

Réponse d'un développeur:

Cela signifie que vous utilisez DsfrNavigation hors de DsfrHeader. Pourquoi ?

Il a effectivement raison, on retrouve DsfrNavigation et DsfrNavigationMenuLink dans le composant Navigation utilisé directement dans App.vue.

Nous n'utilisons pas du tout DsfrHeader alors que son injectionKey est utilisée dans DsfrNavigationMenuLink. Le warning vient sûrement de là.

@abulte abulte added bug Something isn't working and removed upstream labels Dec 10, 2024
@abulte abulte moved this from 💤 Blocked to To Do in Ecosphères Dec 10, 2024
@narduin narduin moved this from To Do to 💤 Blocked in Ecosphères Dec 10, 2024
@narduin narduin moved this from 💤 Blocked to 🏗 In progress in Ecosphères Dec 10, 2024
@narduin narduin moved this from 🏗 In progress to To Do in Ecosphères Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev
Projects
Status: To Do
Development

No branches or pull requests

3 participants