Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-2495] Change the featured market to feature multiple markets from the price feed #411

Merged
merged 17 commits into from
Nov 28, 2024
Merged

[ECO-2495] Change the featured market to feature multiple markets from the price feed #411

merged 17 commits into from
Nov 28, 2024

Conversation

xbtmatt
Copy link
Collaborator

@xbtmatt xbtmatt commented Nov 25, 2024

Description

  • Cache the price feed data with unstable_cache
  • Changed one featured market to multiple markets, in order of descending price delta over the past day (from the price_feed rpc call)
  • Refactor some styled-components to use tailwind instead
  • Rotate through the featured markets with a fade in/out animation

Testing

Check the preview build!

Checklist

  • Did you update relevant documentation?
  • Did you add tests to cover new code or a fixed issue?
  • Did you update the changelog?
  • Did you check all checkboxes from the linked Linear task?

@vercel Vercel
Copy link

vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
emojicoin-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 2:09am
emojicoin-dot-fun-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 2:09am

@xbtmatt xbtmatt requested a review from CRBl69 November 25, 2024 07:37
@xbtmatt xbtmatt requested a review from CRBl69 November 27, 2024 04:41
CRBl69
CRBl69 requested changes Nov 27, 2024
View reviewed changes
src/typescript/sdk/src/indexer-v2/queries/app/home.ts Outdated Show resolved Hide resolved
src/typescript/frontend/src/app/home/page.tsx Outdated Show resolved Hide resolved
src/typescript/sdk/src/indexer-v2/queries/app/home.ts Outdated Show resolved Hide resolved
src/typescript/sdk/src/indexer-v2/queries/app/home.ts Outdated Show resolved Hide resolved
@alnoki alnoki enabled auto-merge (squash) November 28, 2024 02:07
@xbtmatt
Change the default sort to bump order and have the hot market be the …
fc0e9a0 
…latest bumped market
@xbtmatt
Feature several markets at once if possible
7c705d1 
Fetch their data along with the price feed

Refactor `styled-components` components to use tailwind
@xbtmatt
Re-center main card
813dfab
@xbtmatt
Actually re-center main card
cf6fd9b
@xbtmatt
Use useInterval instead of useEffect
c740cce
@xbtmatt
Add price feed test and queries
088f3e7
@xbtmatt
scripts
5f6bcf1
@xbtmatt
Add the new price feed query to the frontend
f883b2a
@xbtmatt
Remove random file
1eece19
@xbtmatt
Fix variable names
f73f725
@xbtmatt
Format/lint
67b1f83
@xbtmatt
Fix test
8211011
@xbtmatt
Add page size to args
f41139a
@xbtmatt
Fix tests and remove unused code
3fa08b9
@xbtmatt
Fix the price feed tests
c93479d 
Add sdk tests for delta percentage

Fix the package.json and turbo.json scripts
@xbtmatt
Set jest timeout
eee2811
@xbtmatt
Fix tests by only comparing volume, since equal volume is non-determi…
b2b1995 
…nistic in terms of sort order from postgres
@alnoki alnoki merged commit 8c3322b into main Nov 28, 2024
7 checks passed
@alnoki alnoki deleted the ECO-2495 branch November 28, 2024 02:13
xbtmatt added a commit that referenced this pull request Nov 28, 2024
@xbtmatt @alnoki
[ECO-2495] Change the featured market to feature multiple markets fro…
6381837 
…m the price feed (#411)

Co-authored-by: alnoki <[email protected]>
@xbtmatt xbtmatt mentioned this pull request Nov 28, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CRBl69 CRBl69 CRBl69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xbtmatt @CRBl69 @alnoki