Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formats' file extensions vs synonyms #421

Open
matuskalas opened this issue Jul 24, 2019 · 2 comments
Open

Formats' file extensions vs synonyms #421

matuskalas opened this issue Jul 24, 2019 · 2 comments
Assignees
Labels
access | publication | release release process, CD, publication, serialisation, etc. broad conceptual issue Discussion around broad-ranging issues, not immediately fully actionable
Milestone

Comments

@matuskalas
Copy link
Member

This issue is about both improving the user experience, and steamlining the development|maintenance work (& cleaning + clearing up) with respect to file extensions. Points to keep in mind or consider:

  • file_extension in EDAM is always lower case and should stay like that (just repeating the fact)
  • synonyms are searchable in ontology browsers
  • we may consider making file_extension a sub-property of hasExactSynonym, but that would disable the possibility of same file extension for multiple formats. Unless we revise the synonyms uniqueness rule (in such case consider also related_term to be non-unique)
  • double-check that ontology-browser searches are case-insensitive
  • maybe we want to avoid copying file_extension to hasExactSynonym(with capitals there). Or have at least very clear rules when to do that and when not.
@matuskalas matuskalas added broad conceptual issue Discussion around broad-ranging issues, not immediately fully actionable access | publication | release release process, CD, publication, serialisation, etc. labels Jul 24, 2019
@matuskalas matuskalas self-assigned this Jul 24, 2019
@joncison
Copy link
Contributor

Thanks for this.

I'm not keen on making file_extension a sub-property of hasExactSynonym - these attributes are fundamentally different types, and it would be confusing / overly complicated to model them like that.

Better (as an EDAM design pattern) to clone all file extensions into hasExactSynonym - thus making them searchable - then have a QA/QC rule/check to enforce that.

I think the capitalisation thing comes in only (and really only) when there is a "canonical" upper-case file extension - there are some of these I think. And for those the key thing is whether the browsers are capitalisation-insensitive, as you say (I suspect they are and thus its a non-issue)

@joncison
Copy link
Contributor

@matuskalas this boils down to two checks for edamverify - once those checks are implemented we can close this issue.

@matuskalas matuskalas added this to the 1.26 milestone May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
access | publication | release release process, CD, publication, serialisation, etc. broad conceptual issue Discussion around broad-ranging issues, not immediately fully actionable
Projects
None yet
Development

No branches or pull requests

2 participants