Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Add checks for subsets #14

Open
3 tasks
matuskalas opened this issue Jul 17, 2019 · 4 comments
Open
3 tasks

Add checks for subsets #14

matuskalas opened this issue Jul 17, 2019 · 4 comments
Assignees
Milestone

Comments

@matuskalas
Copy link
Member

This has to be first cleaned-up in EDAM itself, see edamontology/edamontology#418

  • Every data_|format_|operation_|topic_ concept has data|format|operation|topic subset
  • Everything in the mainline EDAM needs subset bio
  • Subsets are encoded in a desired way, ideally (Semantic) Web-friendly. Needs some more experiments first...
@matuskalas matuskalas added this to the 1.24 milestone Jul 17, 2019
@joncison
Copy link

@matuskalas this check is good, but just to clarify, are you suggesting we refactor the current edam subset to bio ?

I'm not sure it's worth doing that considering downstream applications might need to be changed. But if you really think it's needed pls. post issues to both the docs and main trackers so we can update in both places. Thanks!

@matuskalas
Copy link
Member Author

Yes, that's what I'm suggesting.

I'd be very surprised if that would affect the downstream applications, but we'll see.

Yes indeed, when this will be worked on in the (near or medium) future, we need to change it everywhere. EDAM: edamontology/edamontology#418 Docs: edamontology/edamontologyDocs#28

@joncison
Copy link

An additional check is that a concept has only one of topics, operations, formats or data defined.

@joncison joncison self-assigned this Mar 27, 2020
@joncison
Copy link

joncison commented Mar 27, 2020

QC check done, see https://github.com/edamontology/edamverify/blob/master/queries/subsetMisuse.ipynb

but the check (for now) assumes edam and not bio subset (i.e. current not desired future state). Easy enough to change for this, though.

some feedback on the code appreciated @hmenager and @albangaignard

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants