Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Namespace #89

Merged
merged 8 commits into from
Aug 26, 2023
Merged

Cleanup Namespace #89

merged 8 commits into from
Aug 26, 2023

Conversation

rgb2hsv
Copy link
Contributor

@rgb2hsv rgb2hsv commented Aug 20, 2023 •
edited
Loading

Following changes improve ability of this library to work with other libraries without introducing conflicts or side-effects

  • Puts classes in the "bee" namespace
  • Removes references to using namespace std in the header files

edeforas
edeforas reviewed Aug 26, 2023
View reviewed changes
Copy link
Owner

@edeforas edeforas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, looks good to me .
Can you just rename the namespace bee:: to beednn:: ?

Etienne

@rgb2hsv
Copy link
Contributor Author

rgb2hsv commented Aug 26, 2023

Thanks for your PR, looks good to me . Can you just rename the namespace bee:: to beednn:: ?

Etienne

Fixed!

@rgb2hsv rgb2hsv requested a review from edeforas August 26, 2023 16:08
@edeforas edeforas merged commit cf54e2d into edeforas:master Aug 26, 2023
1 check passed
@edeforas
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeforas edeforas Awaiting requested review from edeforas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgb2hsv @edeforas