Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running dev server against Cloud is broken #18

Open
elprans opened this issue Oct 12, 2024 · 2 comments
Open

Running dev server against Cloud is broken #18

elprans opened this issue Oct 12, 2024 · 2 comments
Assignees

Comments

@elprans
Copy link
Member

elprans commented Oct 12, 2024

pnpm dev seems to force NODE_ENV=development (at least the app ignores .env), and so the EdgeDB client ends up with tlsSecurity=insecure, which does not work with Cloud. Not sure if it's a template issue or an edgedb-js issue, but dev flows should work with Cloud out of the box.

@beerose
Copy link
Member

beerose commented Oct 17, 2024

Yeah, it's next that forces NODE_ENV to be development when running dev server (relevant code).

@scotttrinh, should we skip the insecure setting in the EdgeDB client setup?

@elprans
Copy link
Member Author

elprans commented Oct 17, 2024

The insecure setting should NOT actually drop HTTPS altogether. Instead, it should be ignoring TLS errors. The only place where not doing HTTPS makes sense is in frontend code where the browser will get in the way of insecure requests. Backend should always attempt to do HTTPS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants