Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reusable workflow for GitHub Releases #434

Merged
merged 1 commit into from
Aug 4, 2023
Merged

feat: reusable workflow for GitHub Releases #434

merged 1 commit into from
Aug 4, 2023

Conversation

ernestojeda
Copy link
Contributor

@ernestojeda ernestojeda commented Jul 27, 2023 •
edited
Loading

Functional Test: Autogenerated Release Notes

https://github.com/edgexfoundry/sample-service/actions/runs/5676334799

image

Functional Test: Release notes from CHANGELOG

https://github.com/edgexfoundry/sample-service/actions/runs/5682636035

image

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

Issue Number:

Are there any new imports or modules? If so, what are they used for and why?

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@ernestojeda ernestojeda self-assigned this Jul 27, 2023
@ernestojeda ernestojeda requested a review from bill-mahoney July 27, 2023 16:39
@ernestojeda ernestojeda added the enhancement New feature or request label Jul 27, 2023
bill-mahoney
bill-mahoney approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@bill-mahoney bill-mahoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be good to go over it at the DevOps WG

@ernestojeda ernestojeda merged commit 163b961 into main Aug 4, 2023
edgex-jenkins added a commit that referenced this pull request Aug 4, 2023
@edgex-jenkins
ci: Merge pull request #434 from edgexfoundry/release-action
e187b30 
Signed-off-by: edgex-jenkins <[email protected]>
@ernestojeda ernestojeda added this to the Napa milestone Aug 6, 2023
@ernestojeda ernestojeda linked an issue Aug 6, 2023 that may be closed by this pull request
EdgeX DevOps: Generate GitHub releases on tag creation via GitHub actions #436
Open
@jwagantall jwagantall deleted the release-action branch August 8, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bill-mahoney bill-mahoney bill-mahoney approved these changes

Assignees

@ernestojeda ernestojeda

Labels
enhancement New feature or request
Projects
No open projects
DevOps WG
Status: ✅ Done
Milestone
Napa
Development

Successfully merging this pull request may close these issues.

EdgeX DevOps: Generate GitHub releases on tag creation via GitHub actions
2 participants
@ernestojeda @bill-mahoney