Add MementoOutsideWindow
Exception
#54
Labels
enhancement
New feature or request
good first issue
Good for newcomers
question
Further information is requested
Milestone
Running into and fixing #53 reminded me that we don’t have a specific error for the situation where a memento can be served, but from a time that is beyond the specified
target_window
parameter. Instead, we currently just raise a fairly genericMementoPlaybackError
.We also have a TODO in the code that references this:
wayback/wayback/exceptions.py
Lines 32 to 40 in c066e04
I’m thinking
MementoOutsideWindow
,MementoOutOfWindow
, orMementoOutOfRange
are good candidates for names here. “Range” feels like more traditional wording, but doesn’t clearly match up with the parameter that causes it, which is “target_window.” We could also change the parameter name to “target_range.” ¯\_(ツ)_/¯Regardless of the name, it should be a subclass of
MementoPlaybackError
.The text was updated successfully, but these errors were encountered: