record.c relies on schema.c, change build order #221
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it really depends, why not record this dependency explicitly, rather than rely on a list of files? Why does |
|
record.c depends on schema.c because record.c dumps the schema in the output file. This modifies the linker object inputs order, fixing the linking issue regarding extern schema and schema_len uses in record.c And yes, valid point listing it as a dependency, updated the PR. |
record.c dumps the schema to the output file, thus the dependency. Signed-off-by: Fotios Valasiadis <[email protected]>
fvalasiad
force-pushed
the
fix-build-order
branch
from
650048e to
a0ebaaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.