New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give a error message if no file chosen #16

Open

eeue56 opened this issue Feb 17, 2016 · 0 comments

Labels

Owner

eeue56 commented Feb 17, 2016

Right now, if a user doesn't submit a file, then it will still count as submitted and upload nothing.

Instead, we want to warn and not let people submit when there's no file selected.

The core logic on the server side is here - https://github.com/NoRedInk/take-home/blob/master/instance/server/Generators.elm#L86

But it should be checked client side if possible, here - https://github.com/NoRedInk/take-home/blob/master/instance/server/Client/StartTakeHome/Views.elm#L76

Note that right now, that view is a statically rendered view

eeue56 added the help wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment