Clear localStorage on user logout #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue #64 by modifying the logout functionality to clear the localStorage when a user logs out. Currently, the application does not clear the localStorage, which can lead to potential security risks and incorrect user data being displayed if a new user logs in on the same browser.
Summary of Changes
server.js, modified the logout route handler to include a flagclearLocalStorage: truein the JSON response.src/authentication/firebase.js, added a condition to check for theclearLocalStorageflag in the logout response from the server. If it's true, the localStorage is cleared usinglocalStorage.clear().This change ensures that the localStorage is cleared when a user logs out, providing a more secure and accurate user experience.
Fixes #64.
To checkout this PR branch, run the following command in your terminal:
To make tweaks to this pull request, leave a comment below or in the code.