Skip to content

Commit

Permalink
docs: pr feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
th7nder committed Dec 3, 2024
1 parent c45067a commit c3b5e6e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
4 changes: 2 additions & 2 deletions pallets/storage-provider/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1072,7 +1072,7 @@ pub mod pallet {
///
/// If there is no Storage Provider of given AccountId returns [`Option::None`].
/// May exceptionally return [`Option::None`] when
/// conversion between BlockNumbers fails, but technically should not ever happen.
/// conversion between BlockNumbers fails, but technically should never happen.
pub fn current_deadline(
storage_provider: &T::AccountId,
) -> Option<ExternalDeadlineInfo<BlockNumberFor<T>>> {
Expand Down Expand Up @@ -1102,7 +1102,7 @@ pub mod pallet {
///
/// If there is no Storage Provider of given AccountId returns [`Option::None`].
/// May exceptionally return [`Option::None`] when
/// conversion between BlockNumbers fails, but technically should not ever happen.
/// conversion between BlockNumbers fails, but technically should never happen.
pub fn deadline_info(
storage_provider: &T::AccountId,
deadline_index: u64,
Expand Down
2 changes: 1 addition & 1 deletion primitives/src/pallets.rs
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ sp_api::decl_runtime_apis! {
///
/// If there is no Storage Provider of given AccountId returns [`Option::None`].
/// May exceptionally return [`Option::None`] when
/// conversion between BlockNumbers fails, but technically should not ever happen.
/// conversion between BlockNumbers fails, but technically should never happen.
fn deadline_info(storage_provider: AccountId, deadline_index: u64) -> Option<
DeadlineInfo<
<<Block as sp_runtime::traits::Block>::Header as sp_runtime::traits::Header>::Number
Expand Down
6 changes: 2 additions & 4 deletions storage-provider/server/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -214,19 +214,17 @@ pub struct ServerArguments {

/// Proving Parameters for PoRep proof, corresponding to given `seal_proof` sector size.
/// They are shared across all of the nodes in the network, as the chain stores corresponding Verifying Key parameters.
/// Shared parameters available to get in the repository's README.
///
/// Testing/temporary parameters can be also generated via `polka-storage-provider-client proofs porep-params` command.
/// Testing/temporary parameters can be generated via `polka-storage-provider-client proofs porep-params` command.
/// Note that when you generate keys, for local testnet,
/// **they need to be set** via an extrinsic pallet-proofs::set_porep_verifyingkey.
#[arg(long)]
porep_parameters: PathBuf,

/// Proving Parameters for PoSt proof, corresponding to given `post_proof` sector size.
/// They are shared across all of the nodes in the network, as the chain stores corresponding Verifying Key parameters.
/// Shared parameters available to get in the repository's README
///
/// Testing/temporary parameters can be also generated via `polka-storage-provider-client proofs post-params` command.
/// Testing/temporary parameters can be generated via `polka-storage-provider-client proofs post-params` command.
/// Note that when you generate keys, for local testnet,
/// **they need to be set** via an extrinsic pallet-proofs::set_post_verifyingkey.
#[arg(long)]
Expand Down

0 comments on commit c3b5e6e

Please sign in to comment.