Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: libp2p resolver rfc #629

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

aidan46
Copy link
Contributor

@aidan46 aidan46 commented Dec 9, 2024

Description

This PR adds an RFC for the libp2p Peer ID to multiaddr resolver. This application will be used by clients to find the multiaddr associated with a Peer ID of a deal to fetch the file from the storage provider (using the polka-fetch component) I followed the guidelines described in rfc7322.

A follow-up PR will be created for the scraper that collects on-chain information about deals (both historical and current).

@aidan46 aidan46 added ready for review Review is needed rfc Request for Comments (RFC) labels Dec 9, 2024
@aidan46 aidan46 added this to the Phase 3 milestone Dec 9, 2024
@aidan46 aidan46 self-assigned this Dec 9, 2024
@aidan46 aidan46 linked an issue Dec 9, 2024 that may be closed by this pull request
@aidan46 aidan46 changed the title rfc: Add RFC for libp2p resolver docs: Add RFC for libp2p resolver Dec 9, 2024
@aidan46 aidan46 requested a review from a team December 9, 2024 09:23
rfcs/001-libp2p-resolver.md Outdated Show resolved Hide resolved
rfcs/001-libp2p-resolver.md Outdated Show resolved Hide resolved
rfcs/001-libp2p-resolver.md Outdated Show resolved Hide resolved
rfcs/001-libp2p-resolver.md Outdated Show resolved Hide resolved
rfcs/001-libp2p-resolver.md Outdated Show resolved Hide resolved

## Abstract

This RFC proposes an application for resolving [Peer ID][5]s to [multi-addresses][4] in a [libp2p][1] network.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a separate application for that? Shouldn't it be a part of file retrieval or something similar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the file retrieval interface should be a bit simpler for the end-user, they don't care about peer ID resolver if they already have the multiaddr, they just want to retrieve their file with the multiaddr and the CID. This application should be written so the retriever can use the functionality to resolve the multiaddr from the peer ID.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're proposing a library or an standalone application for resolving PeerIDs?
So this libp2p resolver will be a separate system process?

@jmg-duarte jmg-duarte changed the title docs: Add RFC for libp2p resolver docs: libp2p resolver rfc Dec 10, 2024
@jmg-duarte
Copy link
Collaborator

Should this RFC discuss Kademlia too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Review is needed rfc Request for Comments (RFC)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libp2p Peer ID to multiaddr resolver RFC
3 participants