From eaa65398ee885b34881fc5ffff6e6a8b7536835d Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 25 Mar 2024 21:50:17 +0000 Subject: [PATCH 1/2] build(deps): bump go.einride.tech/sage from 0.276.0 to 0.278.0 in /.sage Bumps [go.einride.tech/sage](https://github.com/einride/sage) from 0.276.0 to 0.278.0. - [Release notes](https://github.com/einride/sage/releases) - [Commits](https://github.com/einride/sage/compare/v0.276.0...v0.278.0) --- updated-dependencies: - dependency-name: go.einride.tech/sage dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- .sage/go.mod | 2 +- .sage/go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.sage/go.mod b/.sage/go.mod index b3a9443..885f00a 100644 --- a/.sage/go.mod +++ b/.sage/go.mod @@ -2,4 +2,4 @@ module go.einride.tech/pid/.sage go 1.19 -require go.einride.tech/sage v0.276.0 +require go.einride.tech/sage v0.278.0 diff --git a/.sage/go.sum b/.sage/go.sum index c05d0ce..c60919c 100644 --- a/.sage/go.sum +++ b/.sage/go.sum @@ -1,2 +1,2 @@ -go.einride.tech/sage v0.276.0 h1:uR5JGcGsAUm1oJ9JQymLGdL+qeLPmXNnmcir7vrIkuM= -go.einride.tech/sage v0.276.0/go.mod h1:EzV5uciFX7/2ho8EKB5K9JghOfXIxlzs694b+Tkl5GQ= +go.einride.tech/sage v0.278.0 h1:I3J2eM/5dIo6YYuozGE2hTNEjJpIaM/jESOY7tlfwZo= +go.einride.tech/sage v0.278.0/go.mod h1:EzV5uciFX7/2ho8EKB5K9JghOfXIxlzs694b+Tkl5GQ= From 90cf39ece1fcc218a8ca788facb6ad8eaef77e5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Veiga?= Date: Wed, 27 Mar 2024 11:46:38 +0100 Subject: [PATCH 2/2] fix: remove deprecated go-review --- .sage/main.go | 8 +------- Makefile | 4 ---- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/.sage/main.go b/.sage/main.go index 3ddd060..ae4a09d 100644 --- a/.sage/main.go +++ b/.sage/main.go @@ -9,7 +9,6 @@ import ( "go.einride.tech/sage/tools/sggo" "go.einride.tech/sage/tools/sggolangcilint" "go.einride.tech/sage/tools/sggolicenses" - "go.einride.tech/sage/tools/sggoreview" "go.einride.tech/sage/tools/sgmdformat" "go.einride.tech/sage/tools/sgyamlfmt" ) @@ -25,7 +24,7 @@ func main() { func Default(ctx context.Context) error { sg.Deps(ctx, ConvcoCheck, FormatMarkdown, FormatYaml) - sg.Deps(ctx, GoLint, GoReview) + sg.Deps(ctx, GoLint) sg.Deps(ctx, GoTest) sg.Deps(ctx, GoModTidy) sg.Deps(ctx, GoLicenses, GitVerifyNoDiff) @@ -42,11 +41,6 @@ func GoTest(ctx context.Context) error { return sggo.TestCommand(ctx).Run() } -func GoReview(ctx context.Context) error { - sg.Logger(ctx).Println("reviewing Go files...") - return sggoreview.Run(ctx) -} - func GoLint(ctx context.Context) error { sg.Logger(ctx).Println("linting Go files...") return sggolangcilint.Run(ctx) diff --git a/Makefile b/Makefile index 0bf45c5..d4af871 100644 --- a/Makefile +++ b/Makefile @@ -75,10 +75,6 @@ go-lint: $(sagefile) go-mod-tidy: $(sagefile) @$(sagefile) GoModTidy -.PHONY: go-review -go-review: $(sagefile) - @$(sagefile) GoReview - .PHONY: go-test go-test: $(sagefile) @$(sagefile) GoTest