-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing functions and docs for LazyFrame #31
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
ce105a6
to
fe1ef97
Compare
Sorry I did not notice the mention.
I think it's a good idea, but it may be difficult given the support for tests for things like head that behave differently in LazyFrame and DataFrame? I'm also concerned about the possibility of files being updated on CI if run as part of
Could this be addressed by updating the function? |
}) | ||
.collect::<std::collections::HashMap<&str, bool>>(); | ||
let mut out = StatisticsOptions::default(); | ||
out.min_value = *hm.get(&"min").unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not use unwrap()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already do input validation on the R side so it's not clear to me how to remove the unwrap()
without duplicating the effort and having too verbose code. Can you help me out on this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but there are too many irrelevant changes to review them all.
Could you please review everything once and undo all the irrelevant changes?
Or split the pull request.
As a general rule, do not touch irrelevant parts.
@eitsupi all changes unrelated to the lazy API have been removed |
No description provided.