Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing functions and docs for LazyFrame #31

Open
wants to merge 85 commits into
base: main
Choose a base branch
from

Conversation

etiennebacher
Copy link
Contributor

No description provided.

@etiennebacher

This comment was marked as outdated.

@eitsupi eitsupi force-pushed the main branch 2 times, most recently from ce105a6 to fe1ef97 Compare November 9, 2024 15:37
@eitsupi
Copy link
Owner

eitsupi commented Nov 16, 2024

Sorry I did not notice the mention.

What do you think about this approach?

I think it's a good idea, but it may be difficult given the support for tests for things like head that behave differently in LazyFrame and DataFrame?

I'm also concerned about the possibility of files being updated on CI if run as part of R CMD check like setup.R, but I think that's a minor issue.

the function above cannot take multiple datasets when testing joins for example.

Could this be addressed by updating the function?

R/dataframe-frame.R Outdated Show resolved Hide resolved
R/io-csv-functions.R Outdated Show resolved Hide resolved
R/io-csv-functions.R Outdated Show resolved Hide resolved
})
.collect::<std::collections::HashMap<&str, bool>>();
let mut out = StatisticsOptions::default();
out.min_value = *hm.get(&"min").unwrap();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not use unwrap()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already do input validation on the R side so it's not clear to me how to remove the unwrap() without duplicating the effort and having too verbose code. Can you help me out on this one?

Copy link
Owner

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but there are too many irrelevant changes to review them all.
Could you please review everything once and undo all the irrelevant changes?
Or split the pull request.

As a general rule, do not touch irrelevant parts.

R/lazyframe-frame.R Outdated Show resolved Hide resolved
R/lazyframe-frame.R Outdated Show resolved Hide resolved
R/lazyframe-frame.R Outdated Show resolved Hide resolved
R/lazyframe-frame.R Outdated Show resolved Hide resolved
R/lazyframe-frame.R Outdated Show resolved Hide resolved
R/lazyframe-frame.R Outdated Show resolved Hide resolved
R/lazyframe-frame.R Outdated Show resolved Hide resolved
R/lazyframe-frame.R Outdated Show resolved Hide resolved
tests/testthat/test-lazyframe-frame.R Outdated Show resolved Hide resolved
@etiennebacher etiennebacher marked this pull request as draft December 9, 2024 15:43
R/lazyframe-frame.R Outdated Show resolved Hide resolved
@etiennebacher etiennebacher requested a review from eitsupi December 9, 2024 16:14
@etiennebacher etiennebacher marked this pull request as ready for review December 9, 2024 16:14
@etiennebacher
Copy link
Contributor Author

@eitsupi all changes unrelated to the lazy API have been removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants