Improve queue discovery #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Dudesons, this is being addressed in #219. I wrote this initially against bullmq which stores queue information differently than the older bull implementation. While your approach would technically find the queues you want added it would wind up setting them up as bullmq queues which may have some unexpected behavior. I'm going to close this PR in favor of #219 which I'm hoping to get done this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to this issue: #130
In our environment we are using the integration nestjs bull and in our redis we don't have
bull:*:metakeys, so the idea is to be able to discover queues without the need to have these keys.Maybe I 'm missing something about the meta keys, I'm beginner with bull system.