Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lens-example pong flag is automatic #1082

Open
phadej opened this issue Dec 3, 2024 · 1 comment
Open

lens-example pong flag is automatic #1082

phadej opened this issue Dec 3, 2024 · 1 comment

Comments

@phadej
Copy link
Collaborator

phadej commented Dec 3, 2024 •
edited
Loading 

flag pong
  default: True
  -- manual: False is the default

which means that solver is free to toggle that, which may cause inconsistent behavior on CI.
If it's intentional, being explicit with manual: False and a comment would be better than relying on the implicit default.
@RyanGlScott
Copy link
Collaborator

That makes sense, and I'd welcome changing this to manual: False. Would you like to submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phadej @RyanGlScott