Provide a numeric version number to compare against. #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including simple example in version.h.in and checking
in the test-{cmake,pkgconfig}.sh scripts.
|
CC: @kintel @pca006132 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1054 +/- ##
==========================================
- Coverage 91.84% 84.69% -7.15%
==========================================
Files 37 62 +25
Lines 4976 9685 +4709
Branches 0 1050 +1050
==========================================
+ Hits 4570 8203 +3633
- Misses 406 1482 +1076 ☔ View full report in Codecov by Sentry. |
|
or maybe two macros, |
Merged
elalish
approved these changes
Nov 18, 2024
kintel
approved these changes
Nov 18, 2024
|
@elalish Perhaps figure out the version.h in WASM mode: openscad/openscad#5434 |
|
Ah I know that one, will open a PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including simple example in version.h.in and checking in the test-{cmake,pkgconfig}.sh scripts.