Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] v1.23.0 Appears to have broken the build artifacts for linux. #2173

Closed
jrlost opened this issue Aug 30, 2023 · 1 comment
Closed

[BUG] v1.23.0 Appears to have broken the build artifacts for linux. #2173

jrlost opened this issue Aug 30, 2023 · 1 comment
Labels

Comments

@jrlost
Copy link

jrlost commented Aug 30, 2023

APM Agent version

The version of the Elastic.Apm nuget package used
1.23.0

Environment

Operating system and version:
Linux

.NET Framework/Core name and version (e.g. .NET 4.6.2, NET Core 3.1.100) :

Application Target Framework(s) (e.g. net462, netcoreapp3.1):

Describe the bug

A clear and concise description of what the bug is.

It appears the work done here: cb2cf0d#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34
has resulted in the build artifact https://github.com/elastic/apm-agent-dotnet/releases/download/v1.23.0/elastic_apm_profiler_1.23.0-linux-x64.zip containing the windows agent and not the linux one; specifically, it has the elastic_apm_profiler.dll and not the libelastic_apm_profiler.so.

To Reproduce

Steps to reproduce the behavior:

  1. Download https://github.com/elastic/apm-agent-dotnet/releases/download/v1.23.0/elastic_apm_profiler_1.23.0-linux-x64.zip
  2. Download https://github.com/elastic/apm-agent-dotnet/releases/download/v1.22.0/elastic_apm_profiler_1.22.0-linux-x64.zip
  3. Compare the files

Expected behavior

A clear and concise description of what you expected to happen.
The linux profiler artifact aligns with the documentation here: https://www.elastic.co/guide/en/apm/agent/dotnet/1.x/setup-auto-instrumentation.html#_general_steps

Actual behavior

The libelastic_apm_profiler.so is missing resulting in auto instrumentation failing.

@jrlost jrlost added the bug Something isn't working label Aug 30, 2023
@Mpdreamz
Copy link
Member

Embarrassed it took me this long to get to this (PTO), many apologies.

I've updated the v1.23.0 release with a proper linux distribution for the profiler.

We didn't quite get the automation for attaching these right for the v1.24.0 release either but the linux profiler has also been attached there now.

Many many thanks for highlighting this @jrlost !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants